Fix up protect from accidental deletion on new objects #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 48s |
jborean93
force-pushed
the
deletion-protection
branch
from
a921ad3 to
52431b3
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The code for handling
protect_from_deletionwhen creating new objects would only work if the cmdlet used contained the-ProtectedFromAccidentalDeletionparameter. Cmdlets likeNew-ADUser,New-ADGroup,New-ADComputerdo not have this parameter so handling for this needed to happen after the object is created with theSet-ADObjectcmdlet.Fixes: #47
ISSUE TYPE
COMPONENT NAME
module_utils/_ADObject.psm1