membership - Improve domainjoin+rename process

[pluto00987]

SUMMARY

This is for situations when joining to a domain with a hostname change too.

When using the Add-Computer cmdlet with NewName specified the process occurs as such:

1. Joins computer to domain using current/old hostname
2. Renames computer and AD computer account to new hostname

This generally works except in cases where the target AD computer account already exists. In such cases it will fail with the exception noted below. This is often the case when one is rebuilding/redeploying/etc an existing machine that uses a specific/static hostname.

With the changes in this PR, the process instead goes in this (IMO) more expected way:

1. Renames computer to new hostname
2. Joins computer to domain using new hostname (using the existing computer account if one is present)

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

membership

ADDITIONAL INFORMATION

Failure encountered when computer account already exists (line numbers per module version 1.4.1):

Computer 'IP-C0A8C10B' was successfully joined to the new domain 'XYZ.com', but renaming it to 'wsdev-s1-1' failed with the following error message: The account already exists.
At line:210 char:13
+             Add-Computer @joinParams
+             ~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (IP-C0A8C10B:String) [Add-Computer], InvalidOperationException
    + FullyQualifiedErrorId : FailToRenameAfterJoinDomain,Microsoft.PowerShell.Commands.AddComputerCommand

ScriptStackTrace:
at <ScriptBlock>, <No file>: line 210

The process I implemented is mentioned in the Add-Computer documentation for the JoinWithNewName Option here

This option is designed to be used with the Rename-Computer cmdlet. If you use the Rename-Computer cmdlet to rename the computer, but do not restart the computer to make the change effective, you can use this parameter to join the computer to a domain with its new name.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0b54366aaf154428ba66f2025911b3c2

✔️ ansible-galaxy-importer SUCCESS in 4m 47s
✔️ build-ansible-collection SUCCESS in 5m 51s

[jborean93]

Thanks for the changes and fixing this problem. Also appreciate the info you shared about the problem, it was very helpful in understanding what was going on.

I've pushed a commit that added a changelog fragment and also some integration tests I added to verify the changes you've made here.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d61859bc787d4a009350b93f49aad678

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 5m 41s