Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm tests #827

Merged

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Dec 13, 2024

SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts.

In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Some of the charts we've used for testing are no longer available at the
old helm repository urls, as they've been moved to oci registries. This
updates those charts.
@gravesm gravesm added test-all-the-targets In order to tell to the integration test splitter to test all targets skip-changelog labels Dec 13, 2024
Copy link

Copy link
Contributor

@yurnov yurnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurnov
Copy link
Contributor

yurnov commented Dec 13, 2024

Thanks, @gravesm for fix

Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/2167124c46aa4eed80064a769a2a2e9f

✔️ ansible-galaxy-importer SUCCESS in 5m 43s
✔️ build-ansible-collection SUCCESS in 5m 53s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c8a33c7 into ansible-collections:main Dec 13, 2024
140 of 141 checks passed
Copy link

patchback bot commented Dec 13, 2024

Backport to stable-3: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply c8a33c7 on top of patchback/backports/stable-3/c8a33c7180035b498549bf3d736e5bf0088e88d7/pr-827

Backporting merged PR #827 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/kubernetes.core.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-3/c8a33c7180035b498549bf3d736e5bf0088e88d7/pr-827 upstream/stable-3
  4. Now, cherry-pick PR Fix helm tests #827 contents into that branch:
    $ git cherry-pick -x c8a33c7180035b498549bf3d736e5bf0088e88d7
    If it'll yell at you with something like fatal: Commit c8a33c7180035b498549bf3d736e5bf0088e88d7 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x c8a33c7180035b498549bf3d736e5bf0088e88d7
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix helm tests #827 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-3/c8a33c7180035b498549bf3d736e5bf0088e88d7/pr-827
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Dec 13, 2024

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/c8a33c7180035b498549bf3d736e5bf0088e88d7/pr-827

Backported as #828

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 13, 2024
SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts.
In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Yuriy Novostavskiy
(cherry picked from commit c8a33c7)
yurnov pushed a commit to yurnov/kubernetes.core that referenced this pull request Dec 14, 2024
SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts.
In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Yuriy Novostavskiy
@yurnov
Copy link
Contributor

yurnov commented Dec 14, 2024

Cherry-pic to stable-3 created as #829

b0z02003 added a commit to b0z02003/kubernetes.core that referenced this pull request Dec 15, 2024
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Dec 16, 2024
This is a backport of PR #827 as merged into main (c8a33c7).
SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts.
In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
@yurnov yurnov mentioned this pull request Dec 26, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 backport-5 mergeit skip-changelog test-all-the-targets In order to tell to the integration test splitter to test all targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants