add support for helm registry login/logout #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abikouo
force-pushed
the
helm_registry_login
branch
from
1d48cab to
8bf598c
Compare
abikouo
force-pushed
the
helm_registry_login
branch
from
e0ce68a to
38c2d95
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 8m 59s |
abikouo
force-pushed
the
helm_registry_login
branch
from
210285b to
f7ae788
Compare
|
|
||
| short_description: login or logout to a registry. | ||
|
|
||
| version_added: "2.5.0" |
There was a problem hiding this comment.
Suggested change
| version_added: "2.5.0" | |
| version_added: "3.0.0" |
| host: localhost:5000 | ||
|
|
||
| # Logout from helm registry | ||
| - name: Logout to Remote registry |
There was a problem hiding this comment.
Suggested change
| - name: Logout to Remote registry | |
| - name: Logout from Remote registry |
| if state == "absent" and "Error: not logged in" in err: | ||
| err = err.replace("Error: ", "") | ||
| changed = False | ||
| else: |
There was a problem hiding this comment.
Shouldn't the value of changed be set to False here?
| chart_ref: "oci://localhost:{{ registry_port }}/helm-charts/python-app" | ||
| chart_version: 0.1.0 | ||
| namespace: "{{ test_namespace[0] }}" | ||
| create_namespace: true |
There was a problem hiding this comment.
Shouldn't we verify the success of this task to ensure that the login is, indeed, successful?
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 7m 59s |
| username: | ||
| description: | ||
| - Provide a username for authenticating with the remote registry. | ||
| - Required when C(state) is set to I(present). |
There was a problem hiding this comment.
Suggested change
| - Required when C(state) is set to I(present). | |
| - Required when I(state) is set to C(present). |
| password: | ||
| description: | ||
| - Provide a password for authenticating with the remote registry. | ||
| - Required when C(state) is set to I(present). |
There was a problem hiding this comment.
Suggested change
| - Required when C(state) is set to I(present). | |
| - Required when I(state) is set to C(present). |
| options: | ||
| state: | ||
| description: | ||
| - If set to I(present) attempt to log in to the remote registry server using the URL specified in C(host). |
There was a problem hiding this comment.
Suggested change
| - If set to I(present) attempt to log in to the remote registry server using the URL specified in C(host). | |
| - If set to C(present) attempt to log in to the remote registry server using the URL specified in I(host). |
| state: | ||
| description: | ||
| - If set to I(present) attempt to log in to the remote registry server using the URL specified in C(host). | ||
| - If set to I(absent) attempt to log out by removing credentials stored for the remote registry server specified in C(host). |
There was a problem hiding this comment.
Suggested change
| - If set to I(absent) attempt to log out by removing credentials stored for the remote registry server specified in C(host). | |
| - If set to C(absent) attempt to log out by removing credentials stored for the remote registry server specified in I(host). |
| RETURN = r""" | ||
| stdout: | ||
| type: str | ||
| description: Full `helm` command stdout, in case you want to display it or examine the event log |
There was a problem hiding this comment.
Suggested change
| description: Full `helm` command stdout, in case you want to display it or examine the event log | |
| description: Full `helm` command stdout, in case you want to display it or examine the event log. |
| sample: '' | ||
| stderr: | ||
| type: str | ||
| description: Full `helm` command stderr, in case you want to display it or examine the event log |
There was a problem hiding this comment.
Suggested change
| description: Full `helm` command stderr, in case you want to display it or examine the event log | |
| description: Full `helm` command stderr, in case you want to display it or examine the event log. |
yurnov
reviewed
Nov 3, 2024
|
|
||
| short_description: login or logout to a registry. | ||
|
|
||
| version_added: "2.5.0" |
There was a problem hiding this comment.
it should be 3.3.0 or even 5.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
closes #578
ISSUE TYPE
COMPONENT NAME
helm_registry_auth