Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option proxy_headers for k8s modules #58

Merged
merged 50 commits into from
Apr 28, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Apr 14, 2021

SUMMARY

Fix on kubernetes-python module kubernetes-client/python#1128
#55

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

k8s authentication

ADDITIONAL INFORMATION

We can now authenticate on k8s cluster using a proxy with proxy headers

- hosts: localhost
  tasks:
  - name: create namespace
    kubernetes.core.k8s:
      defintion:
         name: test
         kind: namespace
      proxy: "http://localhost:3001/"
      proxy_headers: 
          proxy_basic_auth: "username:password"

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #58 (ec66b67) into main (8b2d39d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #58   +/-   ##
=======================================
  Coverage   24.02%   24.02%           
=======================================
  Files           1        1           
  Lines         154      154           
  Branches       29       29           
=======================================
  Hits           37       37           
- Misses        111      112    +1     
+ Partials        6        5    -1     
Impacted Files Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py 24.02% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2d39d...ec66b67. Read the comment docs.

…to 58-add-support-for-proxy_headers-on-authentication.yaml
@Akasurde Akasurde added the type/enhancement New feature or request label Apr 16, 2021
@Akasurde Akasurde added this to the 2.0.0 milestone Apr 16, 2021
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per above

plugins/module_utils/common.py Outdated Show resolved Hide resolved
plugins/doc_fragments/k8s_auth_options.py Outdated Show resolved Hide resolved
plugins/doc_fragments/k8s_auth_options.py Outdated Show resolved Hide resolved
molecule/default/molecule.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from Akasurde April 20, 2021 12:48
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abikouo abikouo merged commit d29f8c1 into ansible-collections:main Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants