Add cache_file parameter for DynamicClient #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
=======================================
Coverage 23.17% 23.17%
=======================================
Files 1 1
Lines 151 151
Branches 24 24
=======================================
Hits 35 35
Misses 111 111
Partials 5 5 Continue to review full report at Codecov.
|
alinabuzachis
force-pushed
the
cache_file
branch
2 times, most recently
from
06d9200 to
117c033
Compare
Akasurde
reviewed
Apr 9, 2021
Akasurde
requested changes
Apr 9, 2021
|
@fabianvf @geerlingguy @gravesm Can you please review this? Thanks in advance. |
alinabuzachis
force-pushed
the
cache_file
branch
2 times, most recently
from
169564c to
d70b848
Compare
|
@fabianvf @geerlingguy Could you please take a look and let us know if it works for you? Thanks. |
alinabuzachis
force-pushed
the
cache_file
branch
from
f2cb448 to
bb7e2d1
Compare
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
cache_file
branch
from
bb7e2d1 to
9a3096e
Compare
Akasurde
approved these changes
Apr 21, 2021
|
@alinabuzachis Thanks for the contribution. @gravesm @fabianvf Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Old PR: ansible-collections/community.kubernetes#405