Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm_template: change order of values_release and values_files #348

Closed
wants to merge 5 commits into from
Closed

helm_template: change order of values_release and values_files #348

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
473f060
fix: change order of values_release and values_files
cvstebut Jan 21, 2022
997e2e8
Merge branch 'ansible-collections:main' into helm_template_fix_values…
cvstebut Jan 26, 2022
cd0ff44
add changelog fragment and unit test
cvstebut Jan 27, 2022
c443642
fix linting issues
cvstebut Jan 27, 2022
30f6107
fix linting issues, take 2
cvstebut Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/modules/helm_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,16 +152,16 @@ def template(
if output_dir:
cmd += " --output-dir=" + output_dir

if values_files:
for values_file in values_files:
cmd += " -f=" + values_file

if release_values:
fd, path = tempfile.mkstemp(suffix=".yml")
with open(path, "w") as yaml_file:
yaml.dump(release_values, yaml_file, default_flow_style=False)
cmd += " -f=" + path

if values_files:
for values_file in values_files:
cmd += " -f=" + values_file

if include_crds:
cmd += " --include-crds"

Expand Down