Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource cache not being used #228

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Sep 8, 2021

SUMMARY

This was some bad copy/paste from the openshift client. The resource
cache was never being used resulting in unnecessary HTTP requests.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

This was some bad copy/paste from the openshift client. The resource
cache was never being used resulting in unnecessary HTTP requests.
@gravesm gravesm requested review from Akasurde and abikouo September 8, 2021 14:31
@gravesm
Copy link
Member Author

gravesm commented Sep 8, 2021

recheck

Copy link
Member

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa. This is super cool.

@gravesm
Copy link
Member Author

gravesm commented Sep 9, 2021

recheck

1 similar comment
@gravesm
Copy link
Member Author

gravesm commented Sep 9, 2021

recheck

@gravesm gravesm added the mergeit label Sep 9, 2021
Copy link

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants