Re-enable support for turbo mode

[gravesm]

SUMMARY

This re-enables the ability to add turbo mode. It also adds a few more
tests to cover some cases that had been broken in turbo mode previously.

Testing with turbo mode is not currently enabled, and would fail until ansible-collections/cloud.common#69 can be merged and a new cloud.common release is done. This also does not add cloud.common to the collection dependencies until a decision has been made about how enabling/disabling turbo mode will work when cloud.common is already installed.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[codecov]

Codecov Report

Merging #169 (d43b846) into main (f98469e) will decrease coverage by 0.37%.
The diff coverage is n/a.

❗ Current head d43b846 differs from pull request most recent head 7f85d58. Consider uploading reports for the commit 7f85d58 to get more accurate results

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
- Coverage   24.40%   24.02%   -0.38%     
==========================================
  Files           1        1              
  Lines         168      154      -14     
  Branches       32       29       -3     
==========================================
- Hits           41       37       -4     
+ Misses        120      112       -8     
+ Partials        7        5       -2     

Impacted Files	Coverage Δ
...ections/kubernetes/core/plugins/action/k8s_info.py	24.02% <0.00%> (-0.38%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2559080...7f85d58. Read the comment docs.

[Akasurde]

LGTM, are we waiting for any additional changes?

[gravesm]

ansible-collections/cloud.common#69 needs to be merged and released before the tests here will pass with turbo mode enabled. If the turbo mode tests are non-voting then we can merge and just have broken tests until the issue with cloud.common is resolved.

[gravesm]

@Akasurde if you want to give the new changes a review, I think we can move forward with this for now and adjust later if we need to.

[Akasurde]

LGTM. I hope we are adding docs are around this env variable in the later PR.

[gravesm]

Yeah, I would like to get turbo mode settled and make sure it's being tested before we publish docs for it.

[gravesm]

To clarify, what I'm suggesting is that the existing environment keyword be used to control this:

- k8s:
    definition:
       ...
  environment:
    ENABLE_TURBO_MODE: true

[goneri]

Oh crap, I totally missed this PR and I started working on this in parallel: #190 and ansible-collections/cloud.common#73

[gravesm]

@goneri Yeah, I think I made this after yours as an alternative to consider. I'm not sure which one is better. Mine seems simpler but I may be missing some reason why we wouldn't want to do things this way.

[goneri]

@goneri Yeah, I think I made this after yours as an alternative to consider. I'm not sure which one is better. Mine seems simpler but I may be missing some reason why we wouldn't want to do things this way.

Yeah. I need to think about this a bit. You're approach is definitely way lighter.

[gravesm]

I believe it should also be easy to set up a non-voting CI job using something like:

environment:
  ENABLE_TURBO_MODE: "{{ lookup('env', 'ENABLE_TURBO_MODE') }}"

at the playbook level in converge.yml.

[goneri]

I suggest we land your PR first. And in the future, if we look for something more elaborate, we can still revisit mine.

[ansible-zuul]

LGTM!