Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reset_then_reuse_values support to helm module #802

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

add reset_then_reuse_values support to helm module #802

wants to merge 6 commits into from

Conversation

b0z02003
Copy link

@b0z02003 b0z02003 commented Nov 30, 2024 •
edited
Loading

SUMMARY

Starting with version 3.14.0, Helm supports --reset-then-reuse-values. As discussed on the original PR. This greatly improves on --reuse-values as it allows to avoid templates errors when new features are added to an upgraded chart.

Closes #803

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

helm

ADDITIONAL INFORMATION

This PR is greatly 'inspired' by #575 and because I wasn't sure how I could provide additional tests for it, I actually copied those build previously for --reuse-values (as it is an improvement on this feature.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/83f476caa6754ad180048e444dda5b9a

✔️ ansible-galaxy-importer SUCCESS in 4m 32s
✔️ build-ansible-collection SUCCESS in 6m 08s

@b0z02003 b0z02003 mentioned this pull request Dec 1, 2024
Open
@yurnov yurnov mentioned this pull request Dec 10, 2024
Open
30 tasks
@b0z02003 b0z02003 force-pushed the helm_reset_then_reuse_values branch from 630d747 to 01b422e Compare December 14, 2024 16:47
@b0z02003 b0z02003 force-pushed the helm_reset_then_reuse_values branch from 01b422e to 6486e64 Compare December 14, 2024 16:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d599dcd8a95847fca57c251d33d9e188

✔️ ansible-galaxy-importer SUCCESS in 5m 13s
✔️ build-ansible-collection SUCCESS in 5m 28s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/a99a1a55ac8b48279f1a348cb9958051

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 5m 50s

abikouo
abikouo requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b0z02003 Thanks for submitting this PR.
In addition to the requested changes, you must include the new test files in main.yml of the corresponding integration test targets.

plugins/modules/helm.py Outdated Show resolved Hide resolved
plugins/modules/helm.py Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7d875e50571f4e85b2e7deec96a15936

✔️ ansible-galaxy-importer SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 5m 24s

@b0z02003
Copy link
Author

@abikouo Thanks for the suggestions ! I've tried to improve on them to also check for helm version and added the integration tests (that was a big oversight on my part, my bad).

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2bfd564abf3947a59fcc353b78b7ba27

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 5m 53s

abikouo
abikouo reviewed Dec 19, 2024
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will address linters issues

plugins/modules/helm.py Outdated Show resolved Hide resolved
plugins/modules/helm.py Outdated Show resolved Hide resolved
plugins/modules/helm.py Outdated Show resolved Hide resolved
@b0z02003 @abikouo
Apply suggestions from code review
2f44938 
fix: linter issues

Co-authored-by: Bikouo Aubin <[email protected]>
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/84be6f6970494700bc7fdf1b82d924d1

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 5m 18s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add support for reset_then_reuse_values to helm upgrade
3 participants
@b0z02003 @abikouo @bidorffOL