Allow managment of security-zone address books with only one element #450

sboyd-m · 2023-09-27T21:11:49Z

SUMMARY

Allow managment of security-zone address books with only one element

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

junos.junos_security_zones

ADDITIONAL INFORMATION

This is simply following a common pattern whereby single elements returned in xml are converted to arrays, such that the code can assume it is in fact an array.

Unfortunately the resulting output is sensitive, but here is the redacted error:

The full traceback is:
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/ansible_collections/ansible/netcommon/plugins/module_utils/network/common/facts/facts.py", line 135, in get_network_resources_facts
    inst.populate_facts(
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/ansible_collections/junipernetworks/junos/plugins/module_utils/network/junos/facts/security_zones/security_zones.py", line 110, in populate_facts
    objs = self.render_config(self.generated_spec, xml)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/ansible_collections/junipernetworks/junos/plugins/module_utils/network/junos/facts/security_zones/security_zones.py", line 231, in render_config
    temp_address_set["name"] = address_set["name"]
fatal: [host.sohonet.dcn]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "config": {
                "functional_zone_management": null,
                "zones": [
                    {
                        "address_book": {
                            "address_sets": [
                                {
                                    "address_sets": null,
                                    "addresses": [
                                        "203.0.113.0"
                                    ],
                                    "description": null,
                                    "name": "really-good-name"
                                }
                            ],
                            "addresses": null
                        },
                        "advance_policy_based_routing_profile": null,
                        "advanced_connection_tracking": null,
                        "application_tracking": null,
                        "description": null,
                        "enable_reverse_reroute": null,
                        "host_inbound_traffic": null,
                        "interfaces": null,
                        "name": "UNTRUST",
                        "screen": null,
                        "source_identity_log": null,
                        "tcp_rst": null,
                        "unidirectional_session_refreshing": null
                    }
                ]
            },
            "running_config": null,
            "state": "merged"
        }
    },
    "msg": "string indices must be integers"
}

softwarefactory-project-zuul · 2023-09-27T23:08:23Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/26d5dbdae6c04b78b8f5b4252bbb2c4f

rohitthakur2590 · 2023-11-27T05:14:54Z

@sboyd-m Thank you for your valuable contribution,
Could you please add a changelog and tests.

github-actions · 2023-12-29T19:13:55Z

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

softwarefactory-project-zuul · 2023-12-29T20:43:32Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7f9d4d94b1214a8c924fb06bc5dd46b8

sboyd-m · 2024-01-02T22:19:15Z

@rohitthakur2590 I am unable to run tests locally, and so cannot add any. I have pushed a changelog, however.

softwarefactory-project-zuul · 2024-01-02T22:20:07Z

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c0168b9febd3493bb4c9b2e6d195d91f

ArjenB96 · 2024-10-07T11:34:27Z

@rohitthakur2590 Possible to get this added? What kind of test would it require? The affected component has a fix, as shown in this PR, that is used very often in the codebase (even in the same file). A bit silly that this has been untouched for over 9 months.

Took me some hours debugging, but I got to the same exact solution.

sboyd-m temporarily deployed to ack September 27, 2023 21:11 — with GitHub Actions Inactive

sboyd-m temporarily deployed to ack September 27, 2023 21:24 — with GitHub Actions Inactive

sboyd-m temporarily deployed to ack September 27, 2023 21:26 — with GitHub Actions Inactive

ashwini-mhatre requested a review from rohitthakur2590 October 4, 2023 13:03

sboyd-m added 3 commits December 29, 2023 09:28

Allow managment of security-zone address books with only one element

a015b87

Formatting

84dc279

Formatting

64a78c5

sboyd-m force-pushed the main branch from c0f9f2d to 64a78c5 Compare December 29, 2023 19:13

sboyd-m had a problem deploying to ack December 29, 2023 19:13 — with GitHub Actions Failure

Add changelog

045b6ad

sboyd-m had a problem deploying to ack January 2, 2024 20:52 — with GitHub Actions Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow managment of security-zone address books with only one element #450

Allow managment of security-zone address books with only one element #450

sboyd-m commented Sep 27, 2023

softwarefactory-project-zuul bot commented Sep 27, 2023

rohitthakur2590 commented Nov 27, 2023

github-actions bot commented Dec 29, 2023

softwarefactory-project-zuul bot commented Dec 29, 2023

sboyd-m commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 2, 2024

ArjenB96 commented Oct 7, 2024 •

edited

Loading

Allow managment of security-zone address books with only one element #450

Are you sure you want to change the base?

Allow managment of security-zone address books with only one element #450

Conversation

sboyd-m commented Sep 27, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

softwarefactory-project-zuul bot commented Sep 27, 2023

rohitthakur2590 commented Nov 27, 2023

github-actions bot commented Dec 29, 2023

softwarefactory-project-zuul bot commented Dec 29, 2023

sboyd-m commented Jan 2, 2024

softwarefactory-project-zuul bot commented Jan 2, 2024

ArjenB96 commented Oct 7, 2024 • edited Loading

ArjenB96 commented Oct 7, 2024 •

edited

Loading