Skip to content

Commit

Permalink
Fix bigquery dataset access iam roles with primative equivalent (#347…
Browse files Browse the repository at this point in the history
…1) (#220)

* account for iam vs primative bigquery roles

* add test, fix description

* s/EDITOR/WRITER

* fix test

* comments

Signed-off-by: Modular Magician <[email protected]>
  • Loading branch information
modular-magician authored May 6, 2020
1 parent 9bfffd5 commit 67df55d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 2 additions & 3 deletions plugins/modules/gcp_bigquery_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@
- Describes the rights granted to the user specified by the other member of
the access object. Primitive, Predefined and custom roles are supported.
Predefined roles that have equivalent primitive roles are swapped by the
API to their Primitive counterparts, and will show a diff post-create. See
[official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
API to their Primitive counterparts. See [official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
required: false
type: str
special_group:
Expand Down Expand Up @@ -310,7 +309,7 @@
- Describes the rights granted to the user specified by the other member of
the access object. Primitive, Predefined and custom roles are supported. Predefined
roles that have equivalent primitive roles are swapped by the API to their
Primitive counterparts, and will show a diff post-create. See [official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
Primitive counterparts. See [official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
returned: success
type: str
specialGroup:
Expand Down
3 changes: 1 addition & 2 deletions plugins/modules/gcp_bigquery_dataset_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@
- Describes the rights granted to the user specified by the other member
of the access object. Primitive, Predefined and custom roles are supported.
Predefined roles that have equivalent primitive roles are swapped by the
API to their Primitive counterparts, and will show a diff post-create.
See [official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
API to their Primitive counterparts. See [official docs](U(https://cloud.google.com/bigquery/docs/access-control)).
returned: success
type: str
specialGroup:
Expand Down

0 comments on commit 67df55d

Please sign in to comment.