Os6 collection (#24)

* adding version changes in galaxy.yaml file * adding changelogs for version 1.0.5 * update ignore-2.10 for sanity test * config module fix to handle issues faced while parsing running config and fixing idempotency issue for banner config * command module change to keep similar changes across all dell networking OSs * terminal plugin fix to send "terminal length 0" command * updated ignore-2.11.txt to handle sanity errors * fixing ansible sanity errors * changes for interface names * fix for issue faced while fetching interface facts * vlan role fix to support vlan append for tagged members * exit handling for multilevel parent * fix for multiline banners * regex fix for handling management acl error in terminal plugin * terminal error regex added for snmp-server user related command * fix for banners * regex fix for sublevel commands * fixed sanity errors found in REDHAT automation hub and interface role readme update
ansible-collections · Feb 16, 2021 · cc2fc12 · cc2fc12
1 parent 4788f93
commit cc2fc12
Show file tree

Hide file tree

Showing 28 changed files with 82 additions and 91 deletions.
diff --git a/.ansible-lint b/.ansible-lint
@@ -0,0 +1,2 @@
+skip_list:
+  - '208'
diff --git a/changelogs/CHANGELOG.rst b/changelogs/CHANGELOG.rst
@@ -4,6 +4,15 @@ Ansible Network Collection for Dell EMC OS6 Release Notes
 
 .. contents:: Topics
 
+v1.0.7
+======
+
+Release Summary
+---------------
+
+- Fixed sanity error found during the sanity tst of automation hub upload
+- os6 interface role readme updated
+
 v1.0.6
 ======
 

diff --git a/changelogs/changelog.yaml b/changelogs/changelog.yaml
@@ -82,23 +82,31 @@ releases:
         - Fix issue in using list of strings for `commands` argument for `os6_command` module
         - Fix issue in using "os6_facts" module for non-legacy n-series platofrms
     fragments:
-      - 1.0.4.yaml
-    release_date: "2020-11-17"
+    - 1.0.4.yaml
+    release_date: '2020-11-17'
   1.0.5:
     changes:
       bugfixes:
         - config module fix to handle issues faced while parsing running config and fixing idempotency issue for banner config
         - command module change to keep similar changes across all dell networking OSs
         - terminal plugin fix to send "terminal length 0" command
     fragments:
-          - 1.0.5.yaml
-    release_date: "2020-12-09"  
+    - 1.0.5.yaml
+    release_date: '2020-12-09'
   1.0.6:
     changes:
       bugfixes:
         - module utils fix for exit handling in multilevel parent commands 
         - config module fix to handle multiline banner
         - terminal plugin fix to handle error reported by management access lists
     fragments:
-          - 1.0.6.yaml
-    release_date: "2020-12-18"
+    - 1.0.6.yaml
+    release_date: '2020-12-18'
+  1.0.7:
+    changes:
+      release_summary:
+        - Fixed sanity error found during the sanity tst of automation hub upload
+        - os6 interface role readme updated for proper syntax of ip address and mask
+    fragments:
+    - 1.0.7.yaml
+    release_date: '2021-02-15'
diff --git a/galaxy.yml b/galaxy.yml
@@ -1,6 +1,6 @@
 namespace: dellemc
 name: os6
-version: 1.0.6
+version: 1.0.7
 readme: README.md
 authors:
 - Komal Patil <[email protected]>

diff --git a/roles/os6_aaa/meta/main.yml b/roles/os6_aaa/meta/main.yml
@@ -1,8 +1,10 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
-  description: The os6_aaa role facilitates the configuration of Authentication Authorization Acccounting (AAA) attributes in devices running Dell EMC Networking Operating Systems. 
+  author: Dell EMC Networking Engineering
+  description: >
+               The os6_aaa role facilitates the configuration of Authentication Authorization Acccounting (AAA) attributes
+               in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os6
diff --git a/roles/os6_aaa/tasks/main.yml b/roles/os6_aaa/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating AAA configuration for os6"
    template:
       src: os6_aaa.j2
-      dest: "{{ build_dir }}/aaa6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/aaa6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning AAA configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_aaa.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_acl/meta/main.yml b/roles/os6_acl/meta/main.yml
@@ -1,8 +1,8 @@
 # Copyright (c) 2017-2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
-  description: The os6_acl role facilitates the configuration of access control list (ACL) attributes in devices running Dell EMC Networking Operating Systems. 
+  author: Dell EMC Networking Engineering
+  description: The os6_acl role facilitates the configuration of access control list (ACL) attributes in devices running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -11,7 +11,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os6
diff --git a/roles/os6_acl/tasks/main.yml b/roles/os6_acl/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating ACL configuration for os6"
    template:
       src: os6_acl.j2
-      dest: "{{ build_dir }}/acl6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/acl6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning ACL configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_acl.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_bgp/tasks/main.yml b/roles/os6_bgp/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating BGP configuration for os6"
    template:
       src: os6_bgp.j2
-      dest: "{{ build_dir }}/bgp6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/bgp6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning BGP configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_bgp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_interface/README.md b/roles/os6_interface/README.md
@@ -30,7 +30,7 @@ Role variables
 | ``admin``      | string: up,down\*              | Configures the administrative state for the interface; configuring the value as administratively "up" enables the interface; configuring the value as administratively "down" disables the interface | os6 |
 | ``suppress_ra`` | string; present,absent     | Configures IPv6 router advertisements if set to present | os6 |
 | ``ip_type_dynamic`` | boolean: true,false           | Configures IP address DHCP if set to true (*ip_and_mask* is ignored if set to true) | os6 |
-| ``ip_and_mask`` | string | configures the specified IP address to the interface VLAN on os6 devices (192.168.11.1/24 format) | os6 |
+| ``ip_and_mask`` | string | configures the specified IP address to the interface VLAN on os6 devices (192.168.11.1 255.255.255.0 format) | os6 |
 | ``ipv6_and_mask`` | string | configures a specified IP address to the interface VLAN on os6 devices (2001:4898:5808:ffa2::1/126 format) | os6 |
 | ``ipv6_reachabletime``       | integer                       | Configures the reachability time for IPv6 neighbor discovery (0 to 3600000), field needs to be left blank to remove the reachability time | os6 |
 | ``ip_helper`` | list | Configures DHCP server address objects (see ``ip_helper.*``) | os6 |
@@ -86,7 +86,7 @@ When `os6_cfg_generate` is set to true, the variable generates the configuration
                 admin: up
         vlan 100:
                 admin: down
-                ip_and_mask:
+                ip_and_mask: 3.3.3.3 255.255.255.0
                 ipv6_and_mask: 2002:4898:5408:faaf::1/64
                 suppress_ra: present
                 ip_helper:

diff --git a/roles/os6_interface/tasks/main.yml b/roles/os6_interface/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating interface configuration for os6"
    template:
       src: os6_interface.j2
-      dest: "{{ build_dir }}/intf6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/intf6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning interface configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_interface.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_lag/tasks/main.yml b/roles/os6_lag/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating LAG configuration for os6"
    template:
       src: os6_lag.j2
-      dest: "{{ build_dir }}/lag6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/lag6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning LAG configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_lag.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_lldp/meta/main.yml b/roles/os6_lldp/meta/main.yml
@@ -1,10 +1,10 @@
 # Copyright (c) 2017-2020 Dell Inc. or its subsidiaries. All Rights Reserved.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: >
-               The os6_lldp role facilitates the configuration of Link Layer Discovery Protocol(LLDP) attributes in devices 
-               running Dell EMC Networking Operating Systems. 
+               The os6_lldp role facilitates the configuration of Link Layer Discovery Protocol(LLDP) attributes in devices
+               running Dell EMC Networking Operating Systems.
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -13,7 +13,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os6
diff --git a/roles/os6_lldp/tasks/main.yml b/roles/os6_lldp/tasks/main.yml
@@ -10,7 +10,7 @@
    register: generate_output
 
  - name: "Provisioning LLDP configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_lldp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_logging/tasks/main.yml b/roles/os6_logging/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating logging configuration for os6"
    template:
       src: os6_logging.j2
-      dest: "{{ build_dir }}/logging6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/logging6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning logging configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_logging.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_ntp/meta/main.yml b/roles/os6_ntp/meta/main.yml
@@ -1,9 +1,9 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os6_ntp role facilitates the configuration of NTP attributes in devices running Dell EMC Networking Operating Systems.
-  company: Dell Inc 
+  company: Dell Inc
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -12,7 +12,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os6
diff --git a/roles/os6_ntp/tasks/main.yml b/roles/os6_ntp/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating NTP configuration for os6"
    template:
       src: os6_ntp.j2
-      dest: "{{ build_dir }}/ntp6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/ntp6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False'))| bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning NTP configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_ntp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_qos/tasks/main.yml b/roles/os6_qos/tasks/main.yml
@@ -2,7 +2,7 @@
 # tasks file for os6
 
  - name: "Provisioning Qos configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_qos.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6
@@ -11,7 +11,7 @@
  - name: "Generating Qos configuration for os6"
    template:
       src: os6_qos.j2
-      dest: "{{ build_dir }}/qos6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/qos6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
diff --git a/roles/os6_snmp/tasks/main.yml b/roles/os6_snmp/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating SNMP configuration for os6"
    template:
       src: os6_snmp.j2
-      dest: "{{ build_dir }}/snmp6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/snmp6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning SNMP configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_snmp.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_system/meta/main.yml b/roles/os6_system/meta/main.yml
@@ -1,9 +1,9 @@
 # Copyright (c) 2020 Dell Inc.
 ---
 galaxy_info:
-  author: Dell EMC Networking Engineering 
+  author: Dell EMC Networking Engineering
   description: The os6_system role facilitates the configuration of system attributes in devices running Dell EMC Networking Operating Systems.
-  company: Dell Inc 
+  company: Dell Inc
   license:  GPLv3
   min_ansible_version: 2.9.6
 
@@ -12,7 +12,7 @@ galaxy_info:
 
   galaxy_tags:
     - networking
-    - dell 
+    - dell
     - emc
     - dellemc
     - os6
diff --git a/roles/os6_system/tasks/main.yml b/roles/os6_system/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating system configuration for os6"
    template:
       src: os6_system.j2
-      dest: "{{ build_dir }}/system6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/system6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning system configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_system.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_users/tasks/main.yml b/roles/os6_users/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating users configuration for os6"
    template:
       src: os6_users.j2
-      dest: "{{ build_dir }}/users6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/users6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning users configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_users.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6

diff --git a/roles/os6_vlan/tasks/main.yml b/roles/os6_vlan/tasks/main.yml
@@ -4,13 +4,13 @@
  - name: "Generating VLAN configuration for os6"
    template:
       src: os6_vlan.j2
-      dest: "{{ build_dir }}/vlan6_{{hostname}}.conf.part"
+      dest: "{{ build_dir }}/vlan6_{{ hostname }}.conf.part"
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6") and ((os6_cfg_generate | default('False')) | bool)
 #   notify: save config os6
    register: generate_output
 
  - name: "Provisioning VLAN configuration for os6"
-   os6_config:
+   dellemc.os6.os6_config:
       src: os6_vlan.j2
    when: (ansible_network_os is defined and ansible_network_os == "dellemc.os6.os6")
 #   notify: save config os6