Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSH resource module implementation #462

Merged
merged 19 commits into from
Nov 13, 2024
Merged

SSH resource module implementation #462

merged 19 commits into from
Nov 13, 2024

Conversation

balasubramaniam-k
Copy link
Contributor

@balasubramaniam-k balasubramaniam-k commented Oct 8, 2024 •
edited
Loading

SUMMARY
Resource module changes for SSH client configurations. SSH server configuration related changes can be accommodated in the same module.

ISSUE TYPE

  • Feature Pull Request

COMPONENT NAME
sonic_ssh

RELATED PR
ansible-network/resource_module_models#275

OUTPUT
regression-2024-10-04-13-18-53.html.pdf
ssh_config_UT_check_mode.log

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

OUTPUT updated
regression-2024-11-12-19-07-20.html.pdf
ssh_config_UT_diff_mode.log

OUTPUT updated - 13/11/2024
regression-2024-11-13-11-29-28.html.pdf
ssh_config_UT_check_mode.log
ssh_config_UT_diff_mode.log

Balasubramaniam K1 added 3 commits October 2, 2024 17:02
Implementation of SSH resource module.
8845d60
Code changes
b35c370 
1. Handling delete of SSH client algorithms (comma separated string)
when the algorithms remain same and the order of algorithms in input
configuration is different from that of existing.
2. Involving cleanup.
Merge branch 'main' into sonic_ssh
ae33eb7
@ArunSaravananBalachandran ArunSaravananBalachandran added the new_resource_module This pull request adds a new resource module label Oct 8, 2024
@balasubramaniam-k balasubramaniam-k mentioned this pull request Oct 8, 2024
Merged
@kerry-meyer
Copy link
Collaborator

I am closing this PR and will re-open it. These operations are intended to clear the failing "changelog" file check.

@kerry-meyer kerry-meyer closed this Nov 7, 2024
@kerry-meyer kerry-meyer reopened this Nov 7, 2024
stalabi1
stalabi1 requested changes Nov 11, 2024
View reviewed changes
plugins/module_utils/network/sonic/facts/ssh/ssh.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/config/ssh/ssh.py Outdated Show resolved Hide resolved
plugins/modules/sonic_ssh.py Outdated Show resolved Hide resolved
plugins/modules/sonic_ssh.py Outdated Show resolved Hide resolved
plugins/modules/sonic_ssh.py Outdated Show resolved Hide resolved
tests/regression/roles/sonic_ssh/defaults/main.yml Outdated Show resolved Hide resolved
tests/regression/roles/sonic_ssh/defaults/main.yml Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/ssh/ssh.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/facts/ssh/ssh.py Outdated Show resolved Hide resolved
plugins/module_utils/network/sonic/config/ssh/ssh.py Outdated Show resolved Hide resolved
@stalabi1 stalabi1 added this to the v3.0.0 milestone Nov 11, 2024
@stalabi1
Copy link
Collaborator

Please post a log showing the output from the test cases or a playbook being executed in diff mode.

kerry-meyer
kerry-meyer requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes and test results look good. Shade has already covered most of the needed incremental change requests.

I am requesting only some minor additional changes to improve readability and to make the suboption descriptions more complete.

I am also posting a question on the defined sequence of regression test tasks.

plugins/modules/sonic_ssh.py Outdated Show resolved Hide resolved
plugins/modules/sonic_ssh.py Show resolved Hide resolved
tests/regression/roles/sonic_ssh/tasks/main.yml Outdated Show resolved Hide resolved
balasubramaniam-k and others added 14 commits November 12, 2024 17:17
@balasubramaniam-k @stalabi1
Update plugins/module_utils/network/sonic/config/ssh/ssh.py
37f9d0f 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/module_utils/network/sonic/config/ssh/ssh.py
f754358 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/module_utils/network/sonic/config/ssh/ssh.py
5aa9ea0 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/module_utils/network/sonic/config/ssh/ssh.py
b09db0a 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/module_utils/network/sonic/facts/ssh/ssh.py
bfee106 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
1c7a135 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
57c16cf 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
68064ce 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
d6a98cc 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @kerry-meyer
Update plugins/modules/sonic_ssh.py
f03e8e2 
Co-authored-by: Kerry Meyer <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
efadfde 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update plugins/modules/sonic_ssh.py
1abd481 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update tests/regression/roles/sonic_ssh/defaults/main.yml
aa833d8 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k @stalabi1
Update tests/regression/roles/sonic_ssh/defaults/main.yml
ba54455 
Co-authored-by: stalabi1 <[email protected]>
@balasubramaniam-k
Copy link
Contributor Author

Please post a log showing the output from the test cases or a playbook being executed in diff mode.

Updated the log in the description.

kerry-meyer
kerry-meyer approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making these additional changes.

The updated code and corresponding test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit e500d90 into ansible-collections:main Nov 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalabi1 stalabi1 stalabi1 requested changes

@kerry-meyer kerry-meyer kerry-meyer approved these changes

Assignees
No one assigned
Labels
new_resource_module This pull request adds a new resource module
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@balasubramaniam-k @kerry-meyer @stalabi1 @ArunSaravananBalachandran