Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error message for port group facts gathering more descriptive #396

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Jun 12, 2024

SUMMARY

I made the error message for port group facts gathering more descriptive to accommodate platforms that don't support the feature.

GitHub Issues

List the GitHub issues impacted by this PR. If no Github issues are affected, please indicate this with "N/A".\

GitHub Issue #
#387
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

sonic_port_group

OUTPUT

facts_gathering.log
regression-2024-06-12-15-13-17.html.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the enhancement New feature or request label Jun 12, 2024
@stalabi1 stalabi1 added this to the v2.5.0 milestone Jun 12, 2024
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing this enhancement to our functionality for querying facts on "all" resource modules on a platform that doesn't support port groups.

The proposed code changes and test results look good.

Approved.

@kerry-meyer kerry-meyer merged commit 3f5ede4 into ansible-collections:main Jun 12, 2024
16 checks passed
@stalabi1 stalabi1 deleted the port_group branch July 10, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants