-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible collections for USGv6R1 related features #374
Ansible collections for USGv6R1 related features #374
Conversation
plugins/module_utils/network/sonic/config/l3_interfaces/l3_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/l3_interfaces/l3_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/l3_interfaces/l3_interfaces.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/network/sonic/config/l3_interfaces/l3_interfaces.py
Outdated
Show resolved
Hide resolved
Thank you for making the incremental changes to address the pending review comments. I triggered a run of the sanity tests after the latest pushes to the PR branch and there are some failures that need to be addressed before this PR can be approved and merged:
Also, the most recently posted regression test summary output is not readable. Please generate a new one that is a readable ".pdf" file (by printing the verbose '.html' regression test summary file for the regression run to a ".pdf" file). |
Co-authored-by: Arun Saravanan Balachandran <[email protected]>
Co-authored-by: Arun Saravanan Balachandran <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed change set and corresponding test results look good.
I am requesting two very minor documentation changes (single line changes). No regression test re-run is needed after pushing these changes.
ipv6: | ||
addresses: | ||
- address: 85::/64 | ||
eui64: True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since deletion of the address causes deletion of the eui64 bool regardless of whether the bool deletion is explicitly requested, the user doesn't need to specify "eui64: True" to do the deletion for this case. It would provide better guidance to our users to omit this line in the example.
Co-authored-by: Kerry Meyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the final set of requested incremental changes.
The current set of proposed changes and corresponding test results look good.
Thank you very much for providing the code changes for support of the USGv6R1 related changes.
Approved.
SUMMARY
Data definitions in 'argspec'.
Implementation of 'facts' to gather facts for the module.
Implementation of 'config' to apply configurations for merged and deleted states.
ISSUE TYPE
COMPONENT NAME
sonic_l3_interfaces
OUTPUT
Test Result:
Regression_USGv6R1_Ansible.pdf
Latest:
regression-2024-06-10-15-57-23.zip
DEPENDANT PR:
ansible-network/resource_module_models#255
Checklist: