Add ability to set gpgcheck for yum repos #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dingus9 Thank you for making time to create a PR and provide a improvement. Can I ask you if you can apply the same change to the other roles as well, so we have a consistent way of configuring repo's? Other people that has both the Agent and Server/Proxy on the same node will have no idempotency, as each role is changing the contents of the repo files. Thank you! |
|
Sure I'll look into that change on the others also |
dingus9
changed the title
dingus9
changed the title
|
Does that look about right? Not sure if I got them all! |
|
Hi @dingus9 Yes, looks very good! Thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add the ability and property(zabbix_repo_yum_gpgcheck) to control gpg key checking on the default yum repo entries
This feature should allow users to more easily toggle gpg key checking with the default yum repo values
ISSUE TYPE
COMPONENT NAME
improvement to role