Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed failing sanity tests when no_log was missing #345

Merged
merged 2 commits into from
Mar 13, 2021

Conversation

D3DeFi
Copy link
Contributor

@D3DeFi D3DeFi commented Mar 13, 2021

SUMMARY

Fix for ansible-collections/overview#45 (comment)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/zabbix_action.py
plugins/modules/zabbix_discovery_rule.py

@D3DeFi D3DeFi added bug Something isn't working module The issue or pull request is related to Zabbix module labels Mar 13, 2021
@codecov
Copy link

codecov bot commented Mar 13, 2021

Codecov Report

Merging #345 (bafd8dc) into main (14cf8b5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   77.32%   77.32%           
=======================================
  Files          19       19           
  Lines        2686     2686           
  Branches      690      690           
=======================================
  Hits         2077     2077           
  Misses        407      407           
  Partials      202      202           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bc7cc...bafd8dc. Read the comment docs.

@D3DeFi D3DeFi merged commit 331c3c4 into ansible-collections:main Mar 13, 2021
@D3DeFi D3DeFi deleted the sanity-fix branch March 13, 2021 15:11
@sky-joker
Copy link
Contributor

Thank you @D3DeFi for the patch!

@felixfontein
Copy link
Contributor

Please note that you are fixing several security vulnerabilities in this PR. They should come with a changelog fragment of type security_fixes, and it would be good if a version of this collection without these vulnerabilities could be released soon.

@D3DeFi D3DeFi mentioned this pull request Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module The issue or pull request is related to Zabbix module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants