-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update php version for Debian 10 #323
Update php version for Debian 10 #323
Conversation
Hi @l00ptr Thank you for making a PR for this. Can you also update the lines: https://github.com/ansible-collections/community.zabbix/blob/main/molecule/zabbix_web/molecule.yml#L58 It seems that this breaks the Molecule testing run. (I can not merge a PR with failing jobs) I am not sure why the Ubuntu 18.04 jobs fails with this, maybe you have an idea? Kind regards, |
Don't know why the jobs fails on Ubuntu 18.04, i will have a look |
don't know what's going on with ubuntu, but the probleme is not related to the PHP version
I am gonna look deeper a little bit later :) |
PHP 7.4 is not packaged for Debian 10. The default version of php on Buster is 7.3
… in python2 (ansible-collections#322) * fix the issue for the unicode strings doesn’t decode in python2 * add the integration test for ansible-collections#314 * add changelog file * add the test for comparing the unicode ansible-collections#322 (comment)
* fixed macos download link
We fix the php version for our tests on Debian Buster to 7.3 instead of 7.4
61d526f
to
c9e7400
Compare
Codecov Report
@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 77.20% 77.32% +0.12%
==========================================
Files 19 19
Lines 2685 2686 +1
Branches 689 690 +1
==========================================
+ Hits 2073 2077 +4
+ Misses 409 407 -2
+ Partials 203 202 -1
Continue to review full report at Codecov.
|
@dj-wasabi we are a few people to hit this problem. The CI doesn't work with ubuntu (MySQL related problem). Please check those PR : Do you have any clue about this problem ? Best regards, |
Hi @l00ptr Yes I have seen it, but I was not able to find a solution for this yet. It seems (Actually 1 link) to be related to the php version of |
Provided PR #344 to fix CI, so I will merge this PR. Thanks! 👍 |
PHP 7.4 is not packaged for Debian 10. The default version of php on Buster is 7.3
SUMMARY
Fix version of PHP
ISSUE TYPE
COMPONENT NAME
role zabbix_web
ADDITIONAL INFORMATION
This role doesn't work on Debian Buster the default PHP version is 7.3 and not 7.4