Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zabbix_host - made interfaces optional for 5.2 #291

Merged
merged 2 commits into from
Jan 7, 2021
Merged

zabbix_host - made interfaces optional for 5.2 #291

merged 2 commits into from
Jan 7, 2021
+32 −1

Conversation

D3DeFi
Copy link
Contributor

@D3DeFi D3DeFi commented Dec 25, 2020 •
edited
Loading

SUMMARY

Fixes #286

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/zabbix_host

@D3DeFi D3DeFi added bug Something isn't working module The issue or pull request is related to Zabbix module labels Dec 25, 2020
@D3DeFi D3DeFi mentioned this pull request Dec 25, 2020
Closed
@codecov
Copy link

codecov bot commented Dec 25, 2020 •
edited
Loading

Codecov Report

Merging #291 (e5e7133) into main (93cccb0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   77.12%   77.13%           
=======================================
  Files          19       19           
  Lines        2675     2676    +1     
  Branches      685      686    +1     
=======================================
+ Hits         2063     2064    +1     
  Misses        409      409           
  Partials      203      203
Impacted Files Coverage Δ
...ns/community/zabbix/plugins/modules/zabbix_host.py 83.54% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e32f76...e52a0f5. Read the comment docs.

@D3DeFi D3DeFi requested a review from sky-joker January 4, 2021 10:04
@D3DeFi
Copy link
Contributor Author

D3DeFi commented Jan 4, 2021

@sky-joker can you please take a look at this one? I would like to have it merged and then proceed to release 1.2.0

@sky-joker
Copy link
Contributor

Thank you @D3DeFi for this patch!
almost LGTM

@D3DeFi D3DeFi merged commit 03a2c58 into ansible-collections:main Jan 7, 2021
@D3DeFi D3DeFi deleted the zabbix-host-52-interfaces branch January 7, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sky-joker sky-joker sky-joker left review comments

Assignees
No one assigned
Labels
bug Something isn't working module The issue or pull request is related to Zabbix module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not use the community collection ?
2 participants
@D3DeFi @sky-joker