Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user_medias to be optional. #264

Merged
merged 8 commits into from
Nov 18, 2020
Merged

Allow user_medias to be optional. #264

merged 8 commits into from
Nov 18, 2020

Conversation

elrondvega
Copy link
Contributor

@elrondvega elrondvega commented Nov 16, 2020

SUMMARY

Allows user_medias to be optional when not set.

fixes #261

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

zabbix_user

ADDITIONAL INFORMATION

Sets the default to None and handles when value is None.


@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #264 (2cfc10b) into main (c8c225f) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   78.40%   78.48%   +0.08%     
==========================================
  Files          19       19              
  Lines        2663     2673      +10     
  Branches      676      684       +8     
==========================================
+ Hits         2088     2098      +10     
  Misses        376      376              
  Partials      199      199              
Impacted Files Coverage Δ
...ns/community/zabbix/plugins/modules/zabbix_user.py 83.41% <0.00%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09660a8...2cfc10b. Read the comment docs.

Copy link
Contributor

@D3DeFi D3DeFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something like this :)

@sky-joker
Copy link
Contributor

Thank you for this patch!
Could you please enter a changelog file and add integration tests to test_zabbix_user?

https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs

Copy link
Contributor

@sky-joker sky-joker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @elrondvega :)

@sky-joker sky-joker merged commit 8cdd89f into ansible-collections:main Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make user_medias optional/override
3 participants