Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable no_log warning for override_password in module zabbix_user #254

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

mikafinja
Copy link
Contributor

SUMMARY

The user module generates the warning: Module did not set no_log for override_password because part of the options name is password. Ansible has a built in checker for fields like this to prevent you from leaking passwords into log files or things like that.
But here the field is just a boolean and therefore no danger of leaking any sensitive information. So the checking mechanism can be turned off to get rid of this warning.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zabbix_user.py

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #254 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   78.77%   78.77%           
=======================================
  Files          19       19           
  Lines        2643     2643           
  Branches      671      671           
=======================================
  Hits         2082     2082           
  Misses        365      365           
  Partials      196      196           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a852e...0037612. Read the comment docs.

@sky-joker
Copy link
Contributor

Thank you @telegnom for this patch.
A changelog file needs when the module feature or options are modified.
So can you please enter a changelog file?

https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs

@mikafinja
Copy link
Contributor Author

Thanks for your help. And as this is my very first commit to an ansible related project I'm not too familiar with the rules, yet. ;)

Copy link
Contributor

@sky-joker sky-joker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@telegnom
LGTM
Thank you for your contribution :)

@sky-joker sky-joker merged commit 472f289 into ansible-collections:main Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants