fix https://github.com/ansible-collections/community.zabbix/issues/1410

[dshuffin]

SUMMARY

Fixes #1410
Solution is based on this discussion: ansible/ansible#84374

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

zabbix_proxy role
zabbis_agent role

ADDITIONAL INFORMATION

[BGmot]

Sorry, I don't like this PR. It just does not look right (overcomplicated?).
In my opinion it's very easy define variables in inventory so you don't need to play with facts.
Waiting for any opinion from other maintainers. I am ok to accept that I am wrong.

[dshuffin]

That would require that you have a host that runs zabbix web interface to be in the same inventory, and that documentation is updated to reflect where variables need to be set. Additionally task "Setting Zabbix API Server Port" needs to be removed as it does nothing useful.

[BGmot]

You don't need a host that runs Zabbix web in the inventory.
This part in your inventory would do the job:

---
all:
  vars:
    test: 443

Agree on documentation.

Additionally task "Setting Zabbix API Server Port" needs to be removed as it does nothing useful
Agree. It's a leftover from pre-httpapi times and the task does not exist in zabbix_server role.

[pyrodie18]

Ya I don't get what the benefit of this change is.

[eb4x]

Waiting for any opinion from other maintainers.

I second this, it doesn't look like the right approach.