Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zabbix_regexp_info module #1415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

masa-orca
Copy link
Collaborator

@masa-orca masa-orca commented Nov 4, 2024

SUMMARY

Add zabbix_regexp_info module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

community.zabbix.zabbix_regexp_info

ADDITIONAL INFORMATION

I create info module which outputs value for community.zabbix.zabbix_regexp (not raw value).


Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.08%. Comparing base (a09cb00) to head (845e8f8).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/zabbix_regexp_info.py 80.48% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1415      +/-   ##
==========================================
+ Coverage   76.29%   78.08%   +1.78%     
==========================================
  Files          45       46       +1     
  Lines        5619     5685      +66     
  Branches     1423     1433      +10     
==========================================
+ Hits         4287     4439     +152     
+ Misses        836      775      -61     
+ Partials      496      471      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@masa-orca
Copy link
Collaborator Author

@pyrodie18 this module will be added 3.3.0?

@pyrodie18
Copy link
Collaborator

Can add it whenever. I approved it was gonna let you merge it

@masa-orca
Copy link
Collaborator Author

Sure.
If I merge, We need to release 2.3.0 after 2.2.0 without minor release. Is it OK to us?

- name: test - try to retrieve regexp
community.zabbix.zabbix_regexp_info:
name: File systems for discovery
register: zbxregexp_get
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't use zbxregexp_get anywhere, should you create an "assert" for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants