Molecule 6 #1303
Merged
Molecule 6 #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want all the logs and help we can get during testing/CI.
Molecule automagically sets these.
Use loop unless we need additional complexity
cgroupns introduced in community.docker 3.0.0
Also, there is no scenario in our CI where we do not want logs.
this does nothing
It's a dependency within our collection and gets installed with it.
The database type is irrelevant.
We can reuse the create/destroy for all roles, as we always need a OS container, and the database container is only needed/created when the test-instance is in a known database group.
It's the same for all roles, it reflects our dependency on community.docker during provisioning.
|
I think the failing tests are flukes, maybe just re-run the failed ones to verify. |
Ya pretty sure they are....rerunning now |
|
Is there a reason not to just move straight to the current version of 24.6.0? ansible/molecule#4136 |
Not really sure, I wasn't aware of the newer releases. It has Python 3.10 as minimum requirement, but I see we bumped testing to 3.11. I'll add a commit to bump to the latest. |
Let's try even newer versions of molecule.
|
Maybe just re-run the failed tests again. |
pyrodie18
approved these changes
Jun 30, 2024
emrocha
pushed a commit
to emrocha/community.zabbix
that referenced
this pull request
Jul 1, 2024
Closed
eb4x
added a commit
to eb4x/community.zabbix
that referenced
this pull request
Jul 7, 2024
This reverts commit 28c4921.
eb4x
added a commit
to eb4x/community.zabbix
that referenced
this pull request
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Upgrading the molecule testing to version 6.
Future molecule wants to eliminate the various drivers, and just have ansible (delegated driver) set up the infrastructure. This PR does that. Creates all networks/containers in
create.ymland destroys them indestroy.yml.ISSUE TYPE
COMPONENT NAME
molecule, ci
ADDITIONAL INFORMATION
A small smattering of other improvements, and just removing stuff that does not need to be there.