Fix check mode always changed

[jeroenvermeulen]

SUMMARY

Prevent ansible.builtin.get_url from causing check_mode (--check) from being always 'changed'.
The problem is described in the get_url module documentation, see the check_mode attibute.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• zabbix_agent
• zabbix_javagateway
• zabbix_proxy
• zabbix_server
• zabbix_web

ADDITIONAL INFORMATION

We run our playbooks with --check every night.
The goal is to see where there is anything not compiant.
We noticed zabbix_agent, zabbix_web and zabbix_server were always 'changed'.
This is a fix / workaround.

[pyrodie18]

@BGmot what are your thoughts on making this change?

[BGmot]

I am ok with this change, it does not really affect our functionality (or testing). Just please let's make sure all the checks pass before we merge.

[jeroenvermeulen]

@BGmot Thank you.
As far as I can see the failing tests were not caused by my code but by a temporary problem in the build system.
For example:

ERROR! Error when getting collection version metadata for community.postgresql:1.7.6 from default (https://galaxy.ansible.com/api/) (HTTP Code: 502, Message: Bad Gateway Code: Unknown)

[BGmot]

Some of them yes, not your code, I am re-running them. But take a look at this one https://github.com/ansible-collections/community.zabbix/actions/runs/7694015337

[jeroenvermeulen]

The run you are pointing at seems to be from PR #1176
It is checking out rev eef22d5 which is part of that PR.

[BGmot]

Apologies. I approved. @pyrodie18 please merge if you don't have objections.