Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add raspberry pi spport #1145

Merged

Conversation

miettal
Copy link
Contributor

@miettal miettal commented Dec 6, 2023

SUMMARY

in case raspberry pi, role scripts mis-detect os type as debian and try to add debian repo url.
This PR change the detection to detect rasberry pi os to get right repo url.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

{agent, javagateway, web, server} role

ADDITIONAL INFORMATION

Copy link
Collaborator

@pyrodie18 pyrodie18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a change fragment and fix the tests that are failing. I'll be honest, I am not familiar with the ansible_lsb.id variable and from the little bit of reading I think it may well cause more problems than its worth just to allow Pi integration which is not something we will officially support since there's no way for us to test the integration on it. @D3DeFi what are your thoughts?

@miettal
Copy link
Contributor Author

miettal commented Dec 7, 2023

Thank you feedback.

Please add a change fragment and fix the tests that are failing.

I see, I continue doing it.
It seems related lsb module is missing, so I try to add apt-install task.

The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'id'. 'dict object' has no attribute 'id'

I think it may well cause more problems

I understood, anyway I continue to work to make/provide workable patch.
I follow project decision of Mergeing this PR, or not.

@miettal miettal force-pushed the feature/raspberry-pi branch 3 times, most recently from 694abdd to f43b88b Compare December 8, 2023 13:02
@miettal
Copy link
Contributor Author

miettal commented Dec 9, 2023

I fixed code and added a fragment.
but Now it seems ci was failed by another reason.

ERROR! Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/v3/collections/community/general/versions/5.4.0/': The read operation timed out

@miettal
Copy link
Contributor Author

miettal commented Dec 24, 2023

@pyrodie18
I'm almost done, but I cannnot pass CI test.
It seems failed test is not related my change.
What I need to do? Can I help something?

@BGmot
Copy link
Collaborator

BGmot commented Dec 24, 2023

It looks like it cannot fine the package https://github.com/ansible-collections/community.zabbix/actions/runs/7307787096/job/19913806734?pr=1145#step:7:228
Can you please take a close look?

@miettal
Copy link
Contributor Author

miettal commented Dec 25, 2023

in centos script, mysql(maria db) 10.8 repo link is hardcorded in

baseurl: "https://mirror.rackspace.com/mariadb/yum/10.8/centos{{ ansible_distribution_major_version }}-amd64"
.
And the url https://mirror.rackspace.com/mariadb/yum/10.8/centos7-amd64/repodata/repomd.xml return 404.

I cheked server in my browser, It seems 10.8 was dropped and 10.8 reached to EOL.
スクリーンショット 2023-12-25 12 24 18
スクリーンショット 2023-12-25 12 24 45

So I guess this CI fails is not related to my change and In order to pass CI changing mysql version in censto script is needed.

@pyrodie18 pyrodie18 merged commit c92ad07 into ansible-collections:main Dec 27, 2023
280 checks passed
@pyrodie18 pyrodie18 mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants