Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ubuntu 18.04 from supported OS list #1026

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

masa-orca
Copy link
Collaborator

SUMMARY
  • Exclude ubuntu 18.04 from supported OS list.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • all roles
ADDITIONAL INFORMATION

@pyrodie18
Copy link
Collaborator

While I don't disagree with this, I think I would also consider this a breaking change which would mean a major release. @BGmot agree/disagree?

@BGmot
Copy link
Collaborator

BGmot commented Jun 30, 2023

We just stop testing against not supported OS so no change for users, I'd say it is not a breaking change. @D3DeFi what do you think?

@pyrodie18
Copy link
Collaborator

OK, but if we introduce a change in the future and it breaks it but we never see it because we're not testing...is that still a breaking change? If a change breaks in the forest but no one sees it...is it still a break?

@BGmot
Copy link
Collaborator

BGmot commented Jun 30, 2023

You are right. Then I guess it's for a major release.

@pyrodie18
Copy link
Collaborator

@masa-orca, we appreciate the contribution but unfortunately given that this is removing functionality, according to the ansible community rules, this would have to be a breaking change that requires a major release. Given that we just did one of those a couple of months ago, I don't see the need to do one right away just to remove something. According to the Zabbix roadmap (https://www.zabbix.com/roadmap#v7_0_LTS), they will be releasing 7.0 at the end of the year and I expect we'll likely do a major release then to depreciate support for 6.2 and 6.4. At that time we'll also remove support for Ubuntu 18.04.

@pyrodie18 pyrodie18 closed this Jul 4, 2023
@masa-orca
Copy link
Collaborator Author

masa-orca commented Jul 4, 2023

Hum... I understand what you say.
I will reopen this pull request at the next major release. Is that okay?

@pyrodie18
Copy link
Collaborator

Actually, you know what. What's do this the right way. I'm going to go ahead and re-open this ticket. I would suggest that you go through and finish all of the work to actually depreciate Debian 10 though. There are variables in in the vars files that are specific to Debian 10. There's probably (although not sure off hand) some tasks too. Go ahead and clean those up as well. We'll get the PR in a state that its ready to go, but realize we won't actually pull it in until we get to work on 3.0.

That work for you? Thanks...Troy

@pyrodie18 pyrodie18 reopened this Jul 4, 2023
@pyrodie18 pyrodie18 changed the base branch from main to 3.0.0 October 6, 2023 18:01
@pyrodie18 pyrodie18 merged commit cf2dc79 into ansible-collections:3.0.0 Oct 6, 2023
249 of 250 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants