win_domain_computer - add offline domain join support

[briantist]

SUMMARY

Looking to add support for offline domain join, similar to the ADComputer DSC resource.

Offline Domain Join is usually done with djoin.exe and lets you pre-create a computer and get back an opaque BLOB, which you can use on a target machine or machine image to join the machine to the domain, without having to contact a domain controller.

A bug I recently found in the DSC resource led me to look at adding the support directly to Ansible instead of continuing to use the DSC resource.

Main changes:

• Add support for doing an offline domain join provision
• Added tests for ODJ
• Optionally return the BLOB from the module

Other changes:

• Leaving off the $ from sam_account_name is no longer an error; it will be added for you
• fixed up tests which were completely broken and unusable, updated their comments to better inform how they could be used locally (they don't run in CI)
• fixed up some syntax and PowerShell calls
• touched up documentation, added examples and notes

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

win_domain_computer

ADDITIONAL INFORMATION

[jborean93]

Have added a few comments.

Just for my general understanding the offline stuff is still creating the domain object in AD, it just handles all the logic to generate the offline join blob right?

[briantist]

Just for my general understanding the offline stuff is still creating the domain object in AD, it just handles all the logic to generate the offline join blob right?

Yes that's correct.

[jborean93]

Looks good, just a question around the temp file deletion handling and if parent dirs are missing. Apart from that I'm happy with the changes.