win_product_facts: fix an issue that the module doesn't correctly convert a product id #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-joker
changed the title
|
Unfortunately, I confirmed the module with the patch doesn’t correctly convert to a string in a part of MAK. |
jborean93
approved these changes
Jun 19, 2021
|
Thanks for fixing this, I've verified this with some eval ISOs and the last digits now match what Windows reports in it's settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The win_product_facts module has an issue that doesn't convert to the correct id from the registered product id in Windows10.(maybe a bug)
This PR will fix the issue.
fixes: #247
I made the patch while referencing the following vbs(productkey.vbs).
https://answers.microsoft.com/en-us/windows/forum/windows_other-windows_install/get-preinstalled-product-key/e39ec36f-ec3b-4495-b049-be02527a21ce
https://answers.microsoft.com/en-us/windows/forum/windows_10-windows_install-winpc/windows-10-activation-error-0x8007007b/45d12b1c-30b1-4001-bc10-0bcd3da7db1f
By the way, the product id correctly gets with the productkey.vbs.
COMPONENT NAME
plugins/modules/win_product_facts.ps1
ADDITIONAL INFORMATION
Tested on Windows 10.