Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win_dhcp_lease Module not Mac Address Conversion not working correclty #291

Closed
daBONDi opened this issue Sep 9, 2021 · 0 comments · Fixed by #427
Closed

win_dhcp_lease Module not Mac Address Conversion not working correclty #291

daBONDi opened this issue Sep 9, 2021 · 0 comments · Fixed by #427

Comments

@daBONDi
Copy link

daBONDi commented Sep 9, 2021

When you set mac to a mac address with ":" it will not convert correctly and script will fail

The Convert-Mac functionis correct, but will not getting called when you add mac-address like in example, so the mac address is wrong on the "Add Reservation/Lease" PS Module

community.windows/plugins/modules/win_dhcp_lease.ps1

Line 126 in 06a9b8d

if ($mac -like "*-*") {

netsandbox added a commit to netsandbox/community.windows that referenced this issue Aug 16, 2022
@netsandbox
fix mac address convert
e62a28c 
This always use the mac address format with dashes.

Fixes ansible-collections#291
@netsandbox netsandbox mentioned this issue Aug 16, 2022
Merged
jborean93 pushed a commit that referenced this issue Oct 3, 2022
@netsandbox
win_dhcp_lease fix MAC address convert and performance improvements (#…
a25949a 
…427)

* fix mac address convert

This always use the mac address format with dashes.

Fixes #291

* call Get-DhcpServerv4Lease once when MAC and IP are defined

If MAC and IP are defined, only try to find existing lease by MAC.
This saves us a second Get-DhcpServerv4Lease call and improve the
performance of this module.

* add changelog for win_dhcp_lease improvements

e62a28c and 976f683
This was referenced Nov 2, 2022
Closed
Closed
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

win_dhcp_lease fix MAC address convert and performance improvements netsandbox/community.windows
1 participant
@daBONDi