Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update community.vmware.vmware_guest_module.rst #1714

Merged

Conversation

cutrightjm
Copy link
Contributor

Replace missing end of sentence

SUMMARY

Previous update to the vmware_guest_module cut off end of sentence, losing context and version info.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

vmware_guest_module

ADDITIONAL INFORMATION

https://docs.ansible.com/ansible/2.9/modules/vmware_guest_module.html

Compare the 'folder' parameter between versions 2.9 and the latest.

Replace missing end of sentence
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3d42ea84aec14f8c893dee7adaadc0eb

✔️ ansible-tox-linters SUCCESS in 8m 54s
✔️ build-ansible-collection SUCCESS in 9m 32s
ansible-test-sanity-docker-devel FAILURE in 10m 38s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 12s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 16s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 23s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 44s
✔️ ansible-galaxy-importer SUCCESS in 4m 12s

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cutrightjm I'm afraid this isn't really a fix. You see, this file is generated from the documentation in the module, so your change will be overwritten next time we do a release. Feel free to change it, but to make sure you should also add the line here:

- 'If multiple machines are found with same name, this parameter is used to identify'
- 'Examples:'

Otherwise LGTM. Thanks!

@mariolenz mariolenz added the documentation Improvements or additions to documentation label Apr 21, 2023
@mariolenz
Copy link
Collaborator

recheck

Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/e915d10e7b524c17adc488deeda3aa7a

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 7m 21s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 48s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 46s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 09s
✔️ ansible-galaxy-importer SUCCESS in 3m 44s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 09ccfdf into ansible-collections:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation mergeit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants