-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update community.vmware.vmware_guest_module.rst #1714
Update community.vmware.vmware_guest_module.rst #1714
Conversation
Replace missing end of sentence
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 54s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cutrightjm I'm afraid this isn't really a fix. You see, this file is generated from the documentation in the module, so your change will be overwritten next time we do a release. Feel free to change it, but to make sure you should also add the line here:
community.vmware/plugins/modules/vmware_guest.py
Lines 112 to 113 in 86447cd
- 'If multiple machines are found with same name, this parameter is used to identify' | |
- 'Examples:' |
Otherwise LGTM. Thanks!
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 35s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 40s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 8m 28s |
Replace missing end of sentence
SUMMARY
Previous update to the vmware_guest_module cut off end of sentence, losing context and version info.
ISSUE TYPE
COMPONENT NAME
vmware_guest_module
ADDITIONAL INFORMATION
https://docs.ansible.com/ansible/2.9/modules/vmware_guest_module.html
Compare the 'folder' parameter between versions 2.9 and the latest.