vmware_cluster_ha - add set of heartbeat datastores

[Nina2244]

SUMMARY

Add the possibility to set the heartbeat datastores of an cluster.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_cluster_ha

ADDITIONAL INFORMATION

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9e42bc38e90148cbb8fbcfac27268b86

✔️ ansible-tox-linters SUCCESS in 19m 20s
✔️ build-ansible-collection SUCCESS in 20m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 42s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 28s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 11s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 29s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 52s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 15m 45s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 51s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/785a3777752244fba2cc9f0b264b670c

✔️ ansible-tox-linters SUCCESS in 18m 15s
✔️ build-ansible-collection SUCCESS in 20m 12s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 03s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 15s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 55s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 12s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 34s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 14m 44s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SUCCESS in 19m 50s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SUCCESS in 49m 29s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 53s

[mariolenz]

@Nina2244 It looks like you broke idempotency somehow:

TASK [vmware_cluster_ha : assert] **********************************************
task path: /home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/vmware_cluster_ha/tasks/main.yml:80
fatal: [testhost]: FAILED! => {
    "assertion": "not change_apd_response_again.changed",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

PLAY RECAP *********************************************************************
testhost                   : ok=23   changed=11   unreachable=0    failed=1    skipped=14   rescued=0    ignored=0

ansible-test-cloud-integration-vcenter7_only-stable214

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c037d29004254ca2aa2602ece718a039

✔️ ansible-tox-linters SUCCESS in 8m 21s
✔️ build-ansible-collection SUCCESS in 9m 07s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 32s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 26s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 49s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 23s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 50s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 14m 06s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 44s

[mariolenz]

@Nina2244 I'm afraid your PR still breaks things:

TASK [vmware_cluster_ha : assert] **********************************************
task path: /home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/vmware_cluster_ha/tasks/main.yml:80
fatal: [testhost]: FAILED! => {
    "assertion": "not change_apd_response_again.changed",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

ansible-test-cloud-integration-vcenter7_only-stable214

[Nina2244]

@mariolenz can you please trigger a recheck? So I can try to fix it. Because there the current check isn't possible to read anymore.

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/233981afb17f460c8b4ad1e6e746fe50

✔️ ansible-tox-linters SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 9m 22s
❌ ansible-test-sanity-docker-devel FAILURE in 10m 20s (non-voting)
⚠️ ansible-test-sanity-docker-milestone CANCELED (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 25s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 17s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 55s
❌ ansible-test-cloud-integration-vcenter7_only-stable214 FAILURE in 15m 29s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ec3c59b8bf174b268e0e03665bd85935

✔️ ansible-tox-linters SUCCESS in 8m 43s
✔️ build-ansible-collection SUCCESS in 9m 33s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 14s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 19s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 10s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 28s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 23s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable214 FAILURE in 12m 29s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 36s

[mariolenz]

@Nina2244 I think the last CI run failed because of #1723