Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_drs_group_manager: Improve error handling #1448

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

vmware_drs_group_manager raises exceptions instead of calling fail_json().

Additionally, if the DRS group doesn't exist the module fails with 'NoneType' object has no attribute 'vm' or 'NoneType' object has no attribute 'host' which isn't really helpful.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_drs_group_manager

ADDITIONAL INFORMATION

#1415

@mariolenz mariolenz force-pushed the vmware_drs_group_manager-error_msg branch from 176ae83 to 9a7706f Compare September 5, 2022 08:14
@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 4m 17s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 36s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 47s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 46s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 21s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 6m 37s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 23s
ansible-test-cloud-integration-vcenter7_2esxi-stable212 FAILURE in 18m 49s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 13m 19s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 43m 31s
✔️ ansible-galaxy-importer SUCCESS in 4m 14s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 10s
✔️ build-ansible-collection SUCCESS in 4m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 15s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 22s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 05s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 16s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 08s
ansible-test-cloud-integration-vcenter7_only-stable212 RETRY_LIMIT in 1h 00m 30s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 20m 11s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 54m 41s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 43m 46s
✔️ ansible-galaxy-importer SUCCESS in 4m 33s

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ ansible-tox-linters SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 5m 05s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 31s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 26s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 22s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 12s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 15s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 17m 24s
ansible-test-cloud-integration-vcenter7_2esxi-stable212 RETRY_LIMIT in 1h 01m 13s
ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 FAILURE in 16m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 43m 54s
✔️ ansible-galaxy-importer SUCCESS in 4m 38s

@mariolenz
Copy link
Collaborator Author

recheck

@mariolenz mariolenz closed this Sep 5, 2022
@mariolenz mariolenz reopened this Sep 5, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ ansible-tox-linters SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 4m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 24s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 13s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 01s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 8m 43s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 5m 16s
✔️ ansible-test-cloud-integration-vcenter7_only-stable212 SUCCESS in 18m 08s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable212 SUCCESS in 17m 15s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_1_of_2 SUCCESS in 52m 06s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable212_2_of_2 SUCCESS in 44m 40s
✔️ ansible-galaxy-importer SUCCESS in 4m 00s

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ ansible-tox-linters SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 3m 53s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 06s
✔️ ansible-test-units-community-vmware-python38 SUCCESS in 4m 27s
✔️ ansible-galaxy-importer SUCCESS in 4m 02s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant