-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmware_drs_group_manager: Improve error handling #1448
vmware_drs_group_manager: Improve error handling #1448
Conversation
176ae83
to
9a7706f
Compare
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 05s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 10s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 4m 07s |
recheck |
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 4m 07s |
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 06s |
SUMMARY
vmware_drs_group_manager
raises exceptions instead of callingfail_json()
.Additionally, if the DRS group doesn't exist the module fails with
'NoneType' object has no attribute 'vm'
or'NoneType' object has no attribute 'host'
which isn't really helpful.ISSUE TYPE
COMPONENT NAME
vmware_drs_group_manager
ADDITIONAL INFORMATION
#1415