vmware_host_passthrough: Fix to be able to specify PCI id in the devices parameter #1365
+306
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-joker
changed the title
sky-joker
changed the title
|
recheck |
|
recheck |
|
recheck |
|
Hi @sky-joker, I think the last failure of the vcenter+2esxi integration test was cause by a recent change. This PR reverts it ansible/ansible-zuul-jobs#1579 |
|
recheck |
mariolenz
approved these changes
Jul 7, 2022
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 4m 37s |
|
Thanks @mariolenz |
1 task
1 task
1 task
|
So, after enabling passthrought for a device, how can it be mapped to a guest with ansible? On my particular case, a NIC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1579
SUMMARY
If ESXi has multiple PCI devices and they are the same name, and you want to enable the passthrough, you need to specify the PCI id.
But the module hasn't been able to specify the PCI id of the PCI device.
This PR is to be able to specify the id in the devices parameter the module has.
fixes: #1364
ISSUE TYPE
COMPONENT NAME
plugins/modules/vmware_host_passthrough.py
ADDITIONAL INFORMATION
tested in vCenter/ESXi 7.0.0