Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare 2.2.0 release #1263

Merged
merged 1 commit into from
Mar 28, 2022
Merged

prepare 2.2.0 release #1263

merged 1 commit into from
Mar 28, 2022

Conversation

mariolenz
Copy link
Collaborator

New major release 2.2.0!

ansible-playbook tools/prepare_release.yml

@ansibullbot ansibullbot added community_review docs needs_triage Needs a first human triage before being processed. labels Mar 25, 2022
@softwarefactory-project-zuul
Copy link

Build failed.

@mariolenz
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@mariolenz mariolenz force-pushed the prepare_2.2.0_release branch from a2bd83a to b42fdb8 Compare March 26, 2022 19:12
@softwarefactory-project-zuul
Copy link

Build succeeded.

goneri
goneri reviewed Mar 28, 2022
View reviewed changes
CHANGELOG.rst Show resolved Hide resolved
goneri
goneri requested changes Mar 28, 2022
View reviewed changes
Copy link
Member

@goneri goneri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I understand correctly the vmware_vm_info change. The fact it's labeled as breaking_change is a problem.

@mariolenz mariolenz force-pushed the prepare_2.2.0_release branch from b42fdb8 to 62d5901 Compare March 28, 2022 16:37
@softwarefactory-project-zuul
Copy link

Build succeeded.

@mariolenz
Copy link
Collaborator Author

I'm not sure if I understand correctly the vmware_vm_info change. The fact it's labeled as breaking_change is a problem.

@goneri As you've already spotted, this wasn't a breaking change. Thanks to @Nina2244 this is fixed now. Could you please review again?

@mariolenz mariolenz requested a review from goneri March 28, 2022 17:12
@goneri goneri added the mergeit label Mar 28, 2022
@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 155ba79 into ansible-collections:main Mar 28, 2022
@mariolenz mariolenz deleted the prepare_2.2.0_release branch March 29, 2022 07:25
@mariolenz
Copy link
Collaborator Author

@goneri I can't find version 2.2.0 on galaxy. Did you release it yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goneri goneri goneri approved these changes

Assignees
No one assigned
Labels
community_review docs mergeit needs_triage Needs a first human triage before being processed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariolenz @goneri @ansibullbot