Skip to content

Commit

Permalink
Fix sanity tests (#1267)
Browse files Browse the repository at this point in the history
Fix sanity tests

SUMMARY
With ansible-core 2.13, there are some new sanity tests that fail (ansible/ansible#77268?).
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
vca_fw
vca_nat
vmware_host_inventory
vmware_vm_inventory
ADDITIONAL INFORMATION
As an example, see this CI run.
edit: Now that the ansible-core stable-2.13 branch exists and the devel branch has been updated to 2.14.0.dev0, I've also added tests/sanity/ignore-2.14.txt. ansible-collections/news-for-maintainers#13

Reviewed-by: sky-joker <[email protected]>
  • Loading branch information
mariolenz authored Mar 30, 2022
1 parent 155ba79 commit 30de1f0
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 0 deletions.
3 changes: 3 additions & 0 deletions plugins/inventory/vmware_host_inventory.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
- Ignores template if resulted in an empty string or None value.
- You can use property specified in I(properties) as variables in the template.
type: list
elements: string
default: ['name']
properties:
description:
Expand All @@ -89,6 +90,7 @@
- Use C(all) to populate all the properties of the virtual machine.
The value C(all) is time consuming operation, do not use unless required absolutely.
type: list
elements: string
default: [ 'name', 'customValue', 'summary.runtime.powerState' ]
with_nested_properties:
description:
Expand Down Expand Up @@ -116,6 +118,7 @@
- Key name is based on snake case of a vim type name; e.g C(host_system) correspond to C(vim.HostSystem)
required: False
type: list
elements: dict
default: []
with_path:
description:
Expand Down
3 changes: 3 additions & 0 deletions plugins/inventory/vmware_vm_inventory.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
- Ignores template if resulted in an empty string or None value.
- You can use property specified in I(properties) as variables in the template.
type: list
elements: string
default: ['config.name + "_" + config.uuid']
properties:
description:
Expand All @@ -90,6 +91,7 @@
- Please refer more VMware guest attributes which can be used as properties
U(https://github.com/ansible/ansible/blob/devel/docs/docsite/rst/scenario_guides/vmware_scenarios/vmware_inventory_vm_attributes.rst)
type: list
elements: string
default: [ 'name', 'config.cpuHotAddEnabled', 'config.cpuHotRemoveEnabled',
'config.instanceUuid', 'config.hardware.numCPU', 'config.template',
'config.name', 'config.uuid', 'guest.hostName', 'guest.ipAddress',
Expand Down Expand Up @@ -125,6 +127,7 @@
- See L(VIM Types,https://pubs.vmware.com/vi-sdk/visdk250/ReferenceGuide/index-mo_types.html)
required: False
type: list
elements: dict
default: []
with_path:
description:
Expand Down
20 changes: 20 additions & 0 deletions tests/sanity/ignore-2.14.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
plugins/modules/vca_fw.py validate-modules:doc-default-does-not-match-spec # deprecated
plugins/modules/vca_fw.py validate-modules:doc-missing-type # deprecated
plugins/modules/vca_fw.py validate-modules:doc-required-mismatch # deprecated
plugins/modules/vca_fw.py validate-modules:no-default-for-required-parameter # deprecated
plugins/modules/vca_fw.py validate-modules:parameter-list-no-elements # deprecated
plugins/modules/vca_fw.py validate-modules:parameter-type-not-in-doc # deprecated
plugins/modules/vca_fw.py validate-modules:undocumented-parameter # deprecated
plugins/modules/vca_nat.py validate-modules:doc-default-does-not-match-spec # deprecated
plugins/modules/vca_nat.py validate-modules:doc-missing-type # deprecated
plugins/modules/vca_nat.py validate-modules:doc-required-mismatch # deprecated
plugins/modules/vca_nat.py validate-modules:no-default-for-required-parameter # deprecated
plugins/modules/vca_nat.py validate-modules:parameter-list-no-elements # deprecated
plugins/modules/vca_nat.py validate-modules:parameter-type-not-in-doc # deprecated
plugins/modules/vca_nat.py validate-modules:undocumented-parameter # deprecated
plugins/modules/vca_vapp.py validate-modules:doc-default-does-not-match-spec # deprecated
plugins/modules/vca_vapp.py validate-modules:doc-missing-type # deprecated
plugins/modules/vca_vapp.py validate-modules:doc-required-mismatch # deprecated
plugins/modules/vca_vapp.py validate-modules:undocumented-parameter # deprecated
plugins/modules/vmware_deploy_ovf.py use-argspec-type-path!skip
plugins/modules/vmware_host_acceptance.py validate-modules:parameter-state-invalid-choice

0 comments on commit 30de1f0

Please sign in to comment.