Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EE ready #83

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Make EE ready #83

merged 1 commit into from
Apr 15, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Try to make this collection EE ready, with tests. Similar to ansible-collections/community.dns#93.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

collection

@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited
Loading

Codecov Report

Merging #83 (5ccf047) into main (e22433b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files          16       16           
  Lines        1545     1545           
  Branches      203      203           
=======================================
  Hits         1273     1273           
  Misses        218      218           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22433b...5ccf047. Read the comment docs.

@felixfontein felixfontein changed the title [WIP] Make EE ready Make EE ready Apr 15, 2022
briantist
briantist approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

NikolayDachev
NikolayDachev approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@NikolayDachev NikolayDachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is ok

@felixfontein felixfontein merged commit 30afb61 into ansible-collections:main Apr 15, 2022
@felixfontein
Copy link
Collaborator Author

@briantist @NikolayDachev thanks for reviewing this!

@felixfontein felixfontein deleted the ee branch April 15, 2022 17:22
@felixfontein felixfontein mentioned this pull request Apr 15, 2022
Closed
@wyoa-bot wyoa-bot bot mentioned this pull request May 25, 2022
Merged
1 task
@renovate renovate bot mentioned this pull request May 25, 2022
Merged
1 task
@felixfontein felixfontein mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolayDachev NikolayDachev NikolayDachev approved these changes

@briantist briantist briantist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @briantist @NikolayDachev