Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command: always return changed=true #50

Merged

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #49.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

command

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #50 (87830ea) into main (48c7920) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          11       11           
  Lines        1223     1223           
  Branches      161      161           
=======================================
  Hits          980      980           
  Misses        184      184           
  Partials       59       59           
Impacted Files Coverage Δ
plugins/modules/command.py 93.75% <ø> (ø)
tests/unit/plugins/modules/test_command.py 98.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c7920...87830ea. Read the comment docs.

@felixfontein felixfontein requested a review from heuels September 26, 2021 19:41
@felixfontein
Copy link
Collaborator Author

@heuels if you have time, can you take a quick look at this one?

Copy link
Collaborator

@heuels heuels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your time and effort 🙏

@felixfontein felixfontein merged commit f9d246c into ansible-collections:main Oct 9, 2021
@felixfontein felixfontein deleted the command-changed branch October 9, 2021 11:36
@felixfontein
Copy link
Collaborator Author

@heuels thanks a lot for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changed: false always
2 participants