Add basic scenario guides #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 80.16% 80.23% +0.06%
==========================================
Files 11 11
Lines 1190 1189 -1
Branches 161 161
==========================================
Hits 954 954
+ Misses 174 173 -1
Partials 62 62
Continue to review full report at Codecov.
|
|
@heuels @NikolayDachev would be glad if you could take a look at the result and tell me whether it looks ok. Thanks! |
heuels
approved these changes
Jun 20, 2021
There was a problem hiding this comment.
@felixfontein, looks awesome, thank you for this!
One thing I'd add is a note about long commands or long router identities, as seen here.
Open
|
@heuels thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds two scenario guides using the extra docs feature. Once this is included in the next Ansible release, this will show up on https://docs.ansible.com/ansible/latest/collections/community/routeros/ !
Right now, you can look at the result of this PR at https://ansible.fontein.de/collections/community/routeros/index.html#plugins-in-community-routeros (note the two links under
Guides):ISSUE TYPE
COMPONENT NAME
docs