Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use of deprecated Ciphers #34

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Disable use of deprecated Ciphers #34

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a689dc7
Disable use of depricated Ciphers
jadyndev Jun 10, 2021
e159bb7
chore: add changelog fragment
jadyndev Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plugins/modules/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@ def ros_api_connect(self, username, password, host, port, use_ssl):
conn_status["connection"]["port"] = port
ctx = ssl.create_default_context()
ctx.check_hostname = False
ctx.set_ciphers('ADH:@SECLEVEL=0')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikolayDachev was there a reason why you added this? Does it not work for you without this line? If yes, we should add a setting for it.

(We should also do that for the line above, check_hostname.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing, with this line I could neither connect to my device when "TLS version" was set to "any", nor when it was set to "only v1.2". So if there's no explanation why this line is needed on some devices, let's just remove it. We can make it configurable if someone reports that it is really needed in some cases.

api = connect(username=username,
password=password,
host=host,
Expand Down