Update _api_data.py

[liquorice-head]

SUMMARY

The behavior of the log and log-prefix fields has been changed. Previously, if these fields were not declared in the code, Ansible would attempt to delete them. Now, if the fields are not declared, Ansible will assign them the default value for the router OS

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• _api_data.py

ADDITIONAL INFORMATION

[felixfontein]

Thanks for your contribution!

[felixfontein]

What's the reason behind this change? Was the behavior always wrong, or did RouterOS's behavior change from one version to another?

[liquorice-head]

As far as I'm concerned, the behavior was always wrong. I have tested on 6.49.10, 6.49.13, 7.14.1. If you use the --diff parameter in ansible with check mode, you will see that each time ansible tries to remove these fields.

[derdeagle]

I can second that. It was always bugging me but I didn't have the time to investigate.

[felixfontein]

Please note that the unit tests now fail, since some of them rely on the old structure of I think ip firewall filter.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (14d89a3) to head (e014564).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #324   +/-   ##
=======================================
  Coverage   84.62%   84.62%           
=======================================
  Files          33       33           
  Lines        4111     4111           
  Branches      879      879           
=======================================
  Hits         3479     3479           
  Misses        452      452           
  Partials      180      180           

Flag	Coverage Δ
integration	66.27% <ø> (ø)
sanity	21.53% <ø> (ø)
units	84.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[liquorice-head]

Please note that the unit tests now fail, since some of them rely on the old structure of I think ip firewall filter.

@felixfontein fixed. please check

[felixfontein]

Thanks, looks good to me!

[felixfontein]

@liquorice-head thanks for your contribution!
@derdeagle thanks for reviewing!