Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when ssl parameter of api is used #3

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

The problem is that the function parameter is called ssl, which hides the ssl module which is also used in that function. This results in error: 'bool' object has no attribute 'create_default_context'.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

api

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #3 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files           9        9           
  Lines        1126     1126           
  Branches      150      150           
=======================================
  Hits          932      932           
  Misses        132      132           
  Partials       62       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5297d4c...af72b88. Read the comment docs.

Copy link
Collaborator

@NikolayDachev NikolayDachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just notice that as well .. thanks !

@felixfontein
Copy link
Collaborator Author

@NikolayDachev feel free to press the Squash+Merge button :)

@NikolayDachev NikolayDachev merged commit 3c0df4b into ansible-collections:main Oct 27, 2020
@felixfontein felixfontein deleted the fix-ssl-api branch October 27, 2020 11:10
@felixfontein
Copy link
Collaborator Author

@NikolayDachev thanks for reviewing and merging! Also congrats on your first merge in this repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants