Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RouterOS 6.x support for '/ip route rule' path #278

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

vint2k
Copy link
Contributor

@vint2k vint2k commented Apr 15, 2024

SUMMARY

Support API path '/ip route rule' for RouterOS 6.x

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify

Copy link

github-actions bot commented Apr 15, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.08%. Comparing base (8351bff) to head (be8546f).
Report is 7 commits behind head on main.

❗ Current head be8546f differs from pull request most recent head 7ea371d. Consider uploading reports for the commit 7ea371d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #278       +/-   ##
===========================================
- Coverage   82.99%   22.08%   -60.91%     
===========================================
  Files          32       18       -14     
  Lines        4051     2196     -1855     
  Branches      873      576      -297     
===========================================
- Hits         3362      485     -2877     
- Misses        506     1683     +1177     
+ Partials      183       28      -155     
Flag Coverage Δ
integration ?
sanity 22.08% <ø> (ø)
units ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for yet another contribution! This one also needs a changelog fragment :)

@vint2k
Copy link
Contributor Author

vint2k commented Apr 18, 2024

done

@felixfontein felixfontein merged commit 9d34cca into ansible-collections:main Apr 18, 2024
47 checks passed
@felixfontein
Copy link
Collaborator

@vint2k thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants