Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for '/interface pppoe-server server' path #273

Conversation

samburney
Copy link
Contributor

SUMMARY

Add support for '/interface pppoe-server server' path.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info
  • api_modify
ADDITIONAL INFORMATION

Tested in RouterOS 6.49.10 and 7.14.2.

RouterOS 7.x supports two additional fields:

  • accept-empty-service
  • comment

Tasks used for testing:

RouterOS 6.49.10

  tasks:
    - name: Add interface pppoe-server server with defaults (RouterOS 6.x)
      when: "'routeros6' in group_names"
      community.routeros.api_modify:
        path: interface pppoe-server server
        handle_entries_content: remove
        data:
          - interface: ether1


    - name: Add interface pppoe-server server with all values set (RouterOS 6.x)
      when: "'routeros6' in group_names"
      community.routeros.api_modify:
        path: interface pppoe-server server
        handle_entries_content: remove
        data:
          - interface: ether2
#            accept-empty-service: false
            authentication: pap,chap
#            comment: Test PPPoE Server
            default-profile: default-encryption
            disabled: false
            keepalive-timeout: 30
            max-mru: 1500
            max-mtu: 1500
            max-sessions: 10
            mrru: 1500
            one-session-per-host: true
            pado-delay: 100
            service-name: 'test_pppoe_server'

RouterOS 7.14.2

  tasks:
    - name: Add interface pppoe-server server with defaults (RouterOS 7.x)
      when: "'routeros6' not in group_names"
      community.routeros.api_modify:
        path: interface pppoe-server server
        handle_entries_content: remove
        data:
          - interface: ether1


    - name: Add interface pppoe-server server with all values set (RouterOS 7.x)
      when: "'routeros6' not in group_names"
      community.routeros.api_modify:
        path: interface pppoe-server server
        handle_entries_content: remove
        data:
          - interface: ether2
            accept-empty-service: false
            authentication: pap,chap
            comment: Test PPPoE Server
            default-profile: default-encryption
            disabled: false
            keepalive-timeout: 30
            max-mru: 1500
            max-mtu: 1500
            max-sessions: 10
            mrru: 1500
            one-session-per-host: true
            pado-delay: 100
            service-name: 'test_pppoe_server'

Resulting api_info output:

RouterOS 6.49.10

### Only defaults
{
    "!accept-empty-service": null,
    "!comment": null,
    ".id": "*4",
    "interface": "ether1"
},

### All values changed
{
    "!accept-empty-service": null,
    "!comment": null,
    ".id": "*5",
    "authentication": "pap,chap",
    "default-profile": "default-encryption",
    "disabled": false,
    "interface": "ether2",
    "keepalive-timeout": 30,
    "max-mru": 1500,
    "max-mtu": 1500,
    "max-sessions": 10,
    "mrru": 1500,
    "one-session-per-host": true,
    "pado-delay": 100,
    "service-name": "test_pppoe_server"
}

RouterOS 7.14.2

### Only defaults
{
    "!accept-empty-service": null,
    "!comment": null,
    ".id": "*4",
    "interface": "ether1"
},

### All values changed
{
    ".id": "*5",
    "accept-empty-service": false,
    "authentication": "pap,chap",
    "comment": "Test PPPoE Server",
    "default-profile": "default-encryption",
    "disabled": false,
    "interface": "ether2",
    "keepalive-timeout": 30,
    "max-mru": 1500,
    "max-mtu": 1500,
    "max-sessions": 10,
    "mrru": 1500,
    "one-session-per-host": true,
    "pado-delay": 100,
    "service-name": "test_pppoe_server"
}

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.99%. Comparing base (a3fbe88) to head (a0ef18e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files          32       32           
  Lines        4051     4051           
  Branches      873      873           
=======================================
  Hits         3362     3362           
  Misses        506      506           
  Partials      183      183           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.08% <ø> (ø)
units 82.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 31, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@samburney samburney marked this pull request as ready for review March 31, 2024 09:47
@felixfontein felixfontein merged commit 62a795f into ansible-collections:main Apr 17, 2024
45 checks passed
@felixfontein
Copy link
Collaborator

@samburney thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants