Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional '/mpls' paths #272

Merged

Conversation

samburney
Copy link
Contributor

SUMMARY
  • Enable '/mpls interface' for use in api_info/api_modify and update fields.
  • Add '/mpls ldp accept-filter' path.
  • Add '/mpls ldp advertise-filter' path.
  • Add '/mpls ldp interface' path.
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • api_info.py
  • api_modify.py

- Enable '/mpls interface' for use in api_info/api_modify and update fields.
- Add '/mpls ldp accept-filter' path.
- Add '/mpls ldp advertise-filter' path.
- Add '/mpls ldp interface' path.
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.99%. Comparing base (a3fbe88) to head (39090d4).
Report is 6 commits behind head on main.

❗ Current head 39090d4 differs from pull request most recent head 95eb6be. Consider uploading reports for the commit 95eb6be to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files          32       32           
  Lines        4051     4051           
  Branches      873      873           
=======================================
  Hits         3362     3362           
  Misses        506      506           
  Partials      183      183           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.08% <ø> (ø)
units 82.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 31, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

@samburney samburney marked this pull request as ready for review March 31, 2024 08:35
@felixfontein felixfontein merged commit 6fde8f3 into ansible-collections:main Apr 18, 2024
47 checks passed
@felixfontein
Copy link
Collaborator

@samburney thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants