Ignore pylint warnings for construct that does not work with Python 2 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 32 32
Lines 4051 4051
Branches 873 873
=======================================
Hits 3362 3362
Misses 506 506
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…Python 2." This reverts commit 407b2ef.
This was referenced Mar 23, 2024
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…ansible-collections#268) * Ignore pylint warnings for construct that does not work with Python 2. * Revert "Ignore pylint warnings for construct that does not work with Python 2." This reverts commit 407b2ef. * Different approach: use ignore.txt since otherwise ansible-core 2.14 tests fail.
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…ansible-collections#268) * Ignore pylint warnings for construct that does not work with Python 2. * Revert "Ignore pylint warnings for construct that does not work with Python 2." This reverts commit 407b2ef. * Different approach: use ignore.txt since otherwise ansible-core 2.14 tests fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes nightly CI: https://github.com/ansible-collections/community.routeros/actions/runs/8399659133/job/23006035379
ISSUE TYPE
COMPONENT NAME
tests/unit/compat/mock.py