Remove default value for "running" field in "interface wireless" #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `running` field can't be configured. By having a default value it's written and shows up in diffs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=======================================
Coverage 82.97% 82.97%
=======================================
Files 32 32
Lines 4046 4046
Branches 871 871
=======================================
Hits 3357 3357
Misses 506 506
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
derdeagle
approved these changes
Mar 2, 2024
felixfontein
approved these changes
Mar 3, 2024
|
It probably makes sense to add a check which prevents |
|
@hansmi @derdeagle thanks! |
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…ible-collections#264) The `running` field can't be configured. By having a default value it's written and shows up in diffs.
samburney
pushed a commit
to samburney/community.routeros
that referenced
this pull request
Mar 30, 2024
…ible-collections#264) The `running` field can't be configured. By having a default value it's written and shows up in diffs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
runningfield can't be configured. By having a default value it's written and shows up in diffs.ISSUE TYPE