Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose config extra fact #23

Merged
merged 16 commits into from
Mar 29, 2021
Merged

Verbose config extra fact #23

merged 16 commits into from
Mar 29, 2021

Conversation

qaxi
Copy link
Contributor

@qaxi qaxi commented Mar 25, 2021

SUMMARY

Every time 'community.routeros.facts' subset 'config' returns data it's status is 'not changed' in perspective of device it is OK, but ...
Returned data are different on every run of 'community.routeros.facts' even configuration on device is not changed

This adds fact ansible_net_config_nonverbose which contain idempotent config (not changing on every community.routeros.facts execution).

Fixes #20

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

'community.routeros.facts' subset 'config'

ADDITIONAL INFORMATION

@qaxi
Copy link
Contributor Author

qaxi commented Mar 25, 2021

Is there any chance to run tests again?

The error message is
"ERROR! Error when getting available collection versions for ansible.netcommon from default (https://galaxy.ansible.com/api/) (HTTP Code: 520, Message: Origin Error Code: Unknown)"

Tests ran OK on https://github.com/qaxi/community.routeros/actions/runs/686061241

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #23 (167553d) into main (36ff772) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   79.98%   80.00%   +0.01%     
==========================================
  Files          11       11              
  Lines        1184     1190       +6     
  Branches      160      161       +1     
==========================================
+ Hits          947      952       +5     
  Misses        175      175              
- Partials       62       63       +1     
Impacted Files Coverage Δ
plugins/modules/facts.py 82.43% <83.33%> (-0.04%) ⬇️
tests/unit/plugins/modules/test_facts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ff772...167553d. Read the comment docs.

changelogs/fragments/1.2.0.yml Outdated Show resolved Hide resolved
changelogs/fragments/23-indempotent_config.yml Outdated Show resolved Hide resolved
plugins/modules/facts.py Show resolved Hide resolved
plugins/modules/facts.py Outdated Show resolved Hide resolved
tests/unit/plugins/modules/test_facts.py Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

I assume your intention is that one of #22 and this PR should get merged?

@qaxi
Copy link
Contributor Author

qaxi commented Mar 26, 2021

Yes, I dont know which one suits you better ...

IMHO I like #22 Verbose config option more.

@qaxi qaxi mentioned this pull request Mar 26, 2021
plugins/modules/facts.py Outdated Show resolved Hide resolved
plugins/modules/facts.py Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

With that typo fixed, I think this is ready for merging! @heuels what do you think?

@heuels
Copy link
Collaborator

heuels commented Mar 28, 2021

@felixfontein, yes, LGTM!

Co-authored-by: Felix Fontein <[email protected]>
@heuels
Copy link
Collaborator

heuels commented Mar 29, 2021

@qaxi, I just noticed that you also have the typo in the changelog filename 👀

@qaxi
Copy link
Contributor Author

qaxi commented Mar 29, 2021

Damn dyslexia ... thank you.

@felixfontein felixfontein merged commit 1c18d34 into ansible-collections:main Mar 29, 2021
@felixfontein
Copy link
Collaborator

@qaxi thanks for this contribution!
@heuels thanks for reviewing!

@felixfontein
Copy link
Collaborator

@heuels should I do a 1.2.0 release soon (today/tomorrow so it can get included in the next Ansible 3.x.0 release)? Or should we wait a bit more if more things come up?

@felixfontein felixfontein mentioned this pull request Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facts subset config is allways "changed"
3 participants