-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose config extra fact #23
Verbose config extra fact #23
Conversation
Is there any chance to run tests again? The error message is Tests ran OK on https://github.com/qaxi/community.routeros/actions/runs/686061241 |
Codecov Report
@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 79.98% 80.00% +0.01%
==========================================
Files 11 11
Lines 1184 1190 +6
Branches 160 161 +1
==========================================
+ Hits 947 952 +5
Misses 175 175
- Partials 62 63 +1
Continue to review full report at Codecov.
|
I assume your intention is that one of #22 and this PR should get merged? |
Yes, I dont know which one suits you better ... IMHO I like #22 Verbose config option more. |
With that typo fixed, I think this is ready for merging! @heuels what do you think? |
@felixfontein, yes, LGTM! |
Co-authored-by: Felix Fontein <[email protected]>
@qaxi, I just noticed that you also have the typo in the changelog filename 👀 |
Damn dyslexia ... thank you. |
@heuels should I do a 1.2.0 release soon (today/tomorrow so it can get included in the next Ansible 3.x.0 release)? Or should we wait a bit more if more things come up? |
SUMMARY
Every time 'community.routeros.facts' subset 'config' returns data it's status is 'not changed' in perspective of device it is OK, but ...
Returned data are different on every run of 'community.routeros.facts' even configuration on device is not changed
This adds fact ansible_net_config_nonverbose which contain idempotent config (not changing on every community.routeros.facts execution).
Fixes #20
ISSUE TYPE
COMPONENT NAME
'community.routeros.facts' subset 'config'
ADDITIONAL INFORMATION