Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some read-only values to the user path #228

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Ref: #213 (comment)

No changelog fragment since the user path will be added in the same release.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

API modules

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (226649a) 83.15% compared to head (62c9ef2) 83.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #228   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files          32       32           
  Lines        4031     4031           
  Branches      867      867           
=======================================
  Hits         3352     3352           
  Misses        494      494           
  Partials      185      185           
Flag Coverage Δ
integration 66.86% <ø> (ø)
sanity 22.12% <ø> (ø)
units 83.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/module_utils/_api_data.py 69.38% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixfontein felixfontein merged commit 6a68469 into ansible-collections:main Oct 7, 2023
44 checks passed
@felixfontein felixfontein deleted the user branch October 7, 2023 12:38
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.routeros/branch/main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant